[Chore] python gateway unable to execute workflow #16969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing default value during the refactor, we refactor the WorkflowTriggerRequest and remove some of defaults value which cause python sdk could not trigger workflow via PythonGateway this patch try to fix it and I have already test in my local env, and it works again now
SbloodyS
changed the title
|
so quick, my bro @SbloodyS |
3 tasks
|
do not merge untill we pass the test of apache/dolphinscheduler-sdk-python#156 |
CI pass and it ready to merge after review pass |
|
|
PTAL to this PR if you have time @SbloodyS @ruanwenjun |
SbloodyS
approved these changes
Jan 22, 2025
|
Thanks all 👍 . and the schedule CI in apache/dolphinscheduler-sdk-python looks good now https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/12919365828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing default value during the refactor,
we refactor the WorkflowTriggerRequest and
remove some of defaults value which cause python
sdk could not trigger workflow via PythonGateway
this patch try to fix it and I have already test
in my local env, and it works again now
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md