Skip to content

Commit

Permalink
[fix](runtime filter) Avoid to use ignored runtime filter (#44708) (#…
Browse files Browse the repository at this point in the history
…44718)

Filter size should be set by a global size instead of a local size. This
behaviour is introduced by #43885 .

pick #44708
  • Loading branch information
Gabriel39 authored Nov 28, 2024
1 parent 755d35c commit 5ca36a4
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions be/src/exprs/runtime_filter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1121,9 +1121,6 @@ Status IRuntimeFilter::send_filter_size(RuntimeState* state, uint64_t local_filt
std::lock_guard l(*local_merge_filters->lock);
local_merge_filters->merge_size_times--;
local_merge_filters->local_merged_size += local_filter_size;
if (_has_local_target) {
set_synced_size(local_filter_size);
}
if (local_merge_filters->merge_size_times) {
return Status::OK();
} else {
Expand Down Expand Up @@ -1546,9 +1543,10 @@ void IRuntimeFilter::update_runtime_filter_type_to_profile(uint64_t local_merge_
std::string IRuntimeFilter::debug_string() const {
return fmt::format(
"RuntimeFilter: (id = {}, type = {}, is_broadcast: {}, "
"build_bf_cardinality: {}, error_msg: {}",
"build_bf_cardinality: {}, ignored: {}, error_msg: {}",
_filter_id, to_string(_runtime_filter_type), _is_broadcast_join,
_wrapper->get_build_bf_cardinality(), _wrapper->_context->err_msg);
_wrapper->get_build_bf_cardinality(), _wrapper->is_ignored(),
_wrapper->_context->err_msg);
}

Status IRuntimeFilter::merge_from(const RuntimePredicateWrapper* wrapper) {
Expand Down

0 comments on commit 5ca36a4

Please sign in to comment.