[chore](Nereids) change some exception type and message

apache · Nov 22, 2024 · 5e4eefe · 5e4eefe
1 parent babd6ce
commit 5e4eefe
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 27 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/Job.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/Job.java
@@ -89,10 +89,6 @@ public ConnectContext getConnectContext() {
 
     public abstract void execute();
 
-    public EventProducer getEventTracer() {
-        throw new UnsupportedOperationException("get_event_tracer is unsupported");
-    }
-
     protected Optional<CopyInResult> invokeRewriteRuleWithTrace(Rule rule, Plan before, Group targetGroup) {
         context.onInvokeRule(rule.getRuleType());
         COUNTER_TRACER.log(CounterEvent.of(Memo.getStateId(),

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/GroupExpressionMatching.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/GroupExpressionMatching.java
@@ -200,7 +200,7 @@ public boolean hasNext() {
         @Override
         public Plan next() {
             if (!hasNext()) {
-                throw new NoSuchElementException();
+                throw new NoSuchElementException("GroupExpressionIterator is empty");
             }
             return results.get(resultIndex++);
         }

diff --git a/...e/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java b/...e/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
@@ -25,7 +25,6 @@
 import org.apache.doris.common.Config;
 import org.apache.doris.common.IdGenerator;
 import org.apache.doris.common.Pair;
-import org.apache.doris.common.UserException;
 import org.apache.doris.common.util.DebugUtil;
 import org.apache.doris.common.util.TimeUtils;
 import org.apache.doris.nereids.glue.translator.ExpressionTranslator;
@@ -272,7 +271,8 @@ private static Map<String, Expression> evalOnBE(Map<String, Map<String, TExpr>>
         try {
             List<Long> backendIds = Env.getCurrentSystemInfo().getAllBackendByCurrentCluster(true);
             if (backendIds.isEmpty()) {
-                throw new UserException("No alive backends");
+                LOG.warn("no available backend ids for folding constant on BE");
+                return Collections.emptyMap();
             }
             Collections.shuffle(backendIds);
             Backend be = Env.getCurrentSystemInfo().getBackend(backendIds.get(0));

diff --git a/...ain/java/org/apache/doris/nereids/rules/expression/rules/RangePartitionValueIterator.java b/...ain/java/org/apache/doris/nereids/rules/expression/rules/RangePartitionValueIterator.java
@@ -57,7 +57,7 @@ public L next() {
             current = doGetNext(current);
             return toLiteral.apply(value);
         }
-        throw new NoSuchElementException();
+        throw new NoSuchElementException("RangePartitionValueIterator is empty");
     }
 
     protected abstract C doGetNext(C current);

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java
@@ -29,7 +29,6 @@
 import org.apache.doris.catalog.PartitionType;
 import org.apache.doris.catalog.RangePartitionItem;
 import org.apache.doris.catalog.TableIf;
-import org.apache.doris.common.AnalysisException;
 import org.apache.doris.common.FeConstants;
 import org.apache.doris.common.Pair;
 import org.apache.doris.nereids.CascadesContext;
@@ -600,7 +599,7 @@ private ColumnStatistic updateMinMaxForPartitionKey(OlapTable olapTable,
         return cache;
     }
 
-    private double convertLegacyLiteralToDouble(LiteralExpr literal) throws AnalysisException {
+    private double convertLegacyLiteralToDouble(LiteralExpr literal) throws org.apache.doris.common.AnalysisException {
         return StatisticsUtil.convertToDouble(literal.getType(), literal.getStringValue());
     }
 
@@ -641,7 +640,7 @@ private ColumnStatistic updateMinMaxForListPartitionKey(OlapTable olapTable,
                 if (minExpr != null) {
                     cache = updateMinMax(cache, minValue, minExpr, maxValue, maxExpr);
                 }
-            } catch (AnalysisException e) {
+            } catch (org.apache.doris.common.AnalysisException e) {
                 LOG.debug(e.getMessage());
             }
         }
@@ -691,7 +690,7 @@ private ColumnStatistic updateMinMaxForTheFirstRangePartitionKey(OlapTable olapT
                 if (minExpr != null) {
                     cache = updateMinMax(cache, minValue, minExpr, maxValue, maxExpr);
                 }
-            } catch (AnalysisException e) {
+            } catch (org.apache.doris.common.AnalysisException e) {
                 LOG.debug(e.getMessage());
             }
         }

diff --git a/...src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTabletsBelongCommand.java b/...src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTabletsBelongCommand.java
@@ -31,6 +31,7 @@
 import org.apache.doris.common.Pair;
 import org.apache.doris.common.util.DebugUtil;
 import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.exceptions.AnalysisException;
 import org.apache.doris.nereids.trees.plans.PlanType;
 import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
 import org.apache.doris.qe.ConnectContext;
@@ -87,7 +88,7 @@ public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exc
                     PrivPredicate.ADMIN.getPrivs().toString());
         }
         if (tabletIds == null || tabletIds.isEmpty()) {
-            throw new Exception("Please supply at least one tablet id");
+            throw new AnalysisException("Please supply at least one tablet id");
         }
 
         // main logic.

diff --git a/...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java b/...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java
@@ -19,6 +19,7 @@
 
 import org.apache.doris.analysis.DefaultValueExprDef;
 import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.nereids.exceptions.AnalysisException;
 
 /**
  * default value of a column.
@@ -77,7 +78,7 @@ public DefaultValue(String value, String exprName, Long precision) {
      */
     public static DefaultValue currentTimeStampDefaultValueWithPrecision(Long precision) {
         if (precision > ScalarType.MAX_DATETIMEV2_SCALE || precision < 0) {
-            throw new IllegalArgumentException("column's default value current_timestamp"
+            throw new AnalysisException("column's default value current_timestamp"
                     + " precision must be between 0 and 6");
         }
         if (precision == 0) {

diff --git a/.../src/main/java/org/apache/doris/nereids/trees/plans/commands/info/PartitionTableInfo.java b/.../src/main/java/org/apache/doris/nereids/trees/plans/commands/info/PartitionTableInfo.java
@@ -28,7 +28,6 @@
 import org.apache.doris.analysis.StringLiteral;
 import org.apache.doris.catalog.AggregateType;
 import org.apache.doris.catalog.PartitionType;
-import org.apache.doris.common.DdlException;
 import org.apache.doris.nereids.analyzer.UnboundFunction;
 import org.apache.doris.nereids.analyzer.UnboundSlot;
 import org.apache.doris.nereids.exceptions.AnalysisException;
@@ -261,16 +260,15 @@ public PartitionDesc convertToPartitionDesc(boolean isExternal) {
                     partitionDescs.size(), createTablePartitionMaxNum));
             }
 
-            try {
-                ArrayList<Expr> exprs = convertToLegacyAutoPartitionExprs(partitionList);
+            ArrayList<Expr> exprs = convertToLegacyAutoPartitionExprs(partitionList);
 
-                // only auto partition support partition expr
-                if (!isAutoPartition) {
-                    if (exprs.stream().anyMatch(expr -> expr instanceof FunctionCallExpr)) {
-                        throw new DdlException("Non-auto partition table not support partition expr!");
-                    }
+            // only auto partition support partition expr
+            if (!isAutoPartition) {
+                if (exprs.stream().anyMatch(expr -> expr instanceof FunctionCallExpr)) {
+                    throw new AnalysisException("Non-auto partition table not support partition expr!");
                 }
-
+            }
+            try {
                 // here we have already extracted identifierPartitionColumns
                 if (partitionType.equals(PartitionType.RANGE.name())) {
                     if (isAutoPartition) {
@@ -293,7 +291,7 @@ public PartitionDesc convertToPartitionDesc(boolean isExternal) {
     }
 
     private static ArrayList<Expr> convertToLegacyAutoPartitionExprs(List<Expression> expressions) {
-        return new ArrayList<>(expressions.stream().map(expression -> {
+        return expressions.stream().map(expression -> {
             if (expression instanceof UnboundSlot) {
                 return new SlotRef(null, ((UnboundSlot) expression).getName());
             } else if (expression instanceof UnboundFunction) {
@@ -303,9 +301,9 @@ private static ArrayList<Expr> convertToLegacyAutoPartitionExprs(List<Expression
                         new FunctionParams(convertToLegacyArguments(function.children())));
             } else {
                 throw new AnalysisException(
-                    "unsupported auto partition expr " + expression.toString());
+                        "unsupported auto partition expr " + expression.toString());
             }
-        }).collect(Collectors.toList()));
+        }).collect(Collectors.toCollection(ArrayList::new));
     }
 
     private static List<Expr> convertToLegacyArguments(List<Expression> children) {

diff --git a/...java/org/apache/doris/nereids/trees/plans/distribute/worker/job/UnassignedJobBuilder.java b/...java/org/apache/doris/nereids/trees/plans/distribute/worker/job/UnassignedJobBuilder.java
@@ -130,7 +130,8 @@ private UnassignedJob buildLeafOrScanJob(
             return unassignedJob;
         }
 
-        throw new IllegalStateException("Unsupported build UnassignedJob for fragment: "
+        throw new IllegalStateException("Cannot generate unassignedJob for fragment"
+                + " has both OlapScanNode and Other ScanNode: "
                 + planFragment.getExplainString(TExplainLevel.VERBOSE));
     }