Skip to content

Commit

Permalink
[fix](agg) Aggregating string types with null values may result in in…
Browse files Browse the repository at this point in the history
…correct result when compaction (#42512)

Follow-up for #42067.
  • Loading branch information
liaoxin01 authored and xiaokang committed Nov 19, 2024
1 parent 4a6b26e commit 64bde86
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions be/src/vec/olap/vertical_block_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,10 @@ size_t VerticalBlockReader::_copy_agg_data() {
auto& dst_column = _stored_data_columns[idx];
if (_stored_has_variable_length_tag[idx]) {
//variable length type should replace ordered
dst_column->clear();
for (size_t i = 0; i < copy_size; i++) {
auto& ref = _stored_row_ref[i];
dst_column->replace_column_data(*ref.block->get_by_position(idx).column,
ref.row_pos, i);
dst_column->insert_from(*ref.block->get_by_position(idx).column, ref.row_pos);
}
} else {
for (auto& it : _temp_ref_map) {
Expand Down

0 comments on commit 64bde86

Please sign in to comment.