Skip to content

Commit

Permalink
[fix](chore) update some CHECK to CHECK_EQ, to print more details whi…
Browse files Browse the repository at this point in the history
…le CHECK failed (#33709)
  • Loading branch information
zhannngchen committed Jun 14, 2024
1 parent 36a4331 commit cb516b7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions be/src/olap/rowset/segment_v2/segment_writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*
{loc.rowset_id, loc.segment_id, DeleteBitmap::TEMP_VERSION_COMMON}, loc.row_id);
}
}
CHECK(use_default_or_null_flag.size() == num_rows);
CHECK_EQ(use_default_or_null_flag.size(), num_rows);

if (config::enable_merge_on_write_correctness_check) {
_tablet->add_sentinel_mark_to_delete_bitmap(_mow_context->delete_bitmap.get(),
Expand Down Expand Up @@ -582,7 +582,7 @@ Status SegmentWriter::fill_missing_columns(vectorized::MutableColumns& mutable_f
// create old value columns
const auto& cids_missing = _opts.rowset_ctx->partial_update_info->missing_cids;
auto old_value_block = _tablet_schema->create_block_by_cids(cids_missing);
CHECK(cids_missing.size() == old_value_block.columns());
CHECK_EQ(cids_missing.size(), old_value_block.columns());
auto mutable_old_columns = old_value_block.mutate_columns();
bool has_row_column = _tablet_schema->store_row_column();
// record real pos, key is input line num, value is old_block line num
Expand Down Expand Up @@ -1073,7 +1073,7 @@ Status SegmentWriter::_write_short_key_index() {
}

Status SegmentWriter::_write_primary_key_index() {
CHECK(_primary_key_index_builder->num_rows() == _row_count);
CHECK_EQ(_primary_key_index_builder->num_rows(), _row_count);
return _primary_key_index_builder->finalize(_footer.mutable_primary_key_index_meta());
}

Expand Down

0 comments on commit cb516b7

Please sign in to comment.