-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Enhancement] (nereids)implement DropStoragePolicyCommand in nereids (#…
- Loading branch information
1 parent
d41147f
commit d0f09fb
Showing
7 changed files
with
157 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
...src/main/java/org/apache/doris/nereids/trees/plans/commands/DropStoragePolicyCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.common.ErrorCode; | ||
| import org.apache.doris.common.ErrorReport; | ||
| import org.apache.doris.mysql.privilege.PrivPredicate; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.policy.DropPolicyLog; | ||
| import org.apache.doris.policy.PolicyTypeEnum; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
|
|
||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| /** | ||
| * drop storage policy command | ||
| */ | ||
| public class DropStoragePolicyCommand extends DropCommand { | ||
| public static final Logger LOG = LogManager.getLogger(DropStoragePolicyCommand.class); | ||
| private final boolean ifExists; | ||
| private final String policyName; | ||
|
|
||
| /** | ||
| * constructor | ||
| */ | ||
| public DropStoragePolicyCommand(String policyName, boolean ifExists) { | ||
| super(PlanType.DROP_STORAGE_POLICY_COMMAND); | ||
| this.policyName = policyName; | ||
| this.ifExists = ifExists; | ||
| } | ||
|
|
||
| @Override | ||
| public void doRun(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| if (!Env.getCurrentEnv().getAccessManager() | ||
| .checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, | ||
| PrivPredicate.ADMIN.getPrivs().toString()); | ||
| } | ||
| // Drop the storage policy | ||
| DropPolicyLog dropPolicyLog = new DropPolicyLog(PolicyTypeEnum.STORAGE, policyName); | ||
| Env.getCurrentEnv().getPolicyMgr().dropPolicy(dropPolicyLog, ifExists); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitDropStoragePolicyCommand(this, context); | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
regression-test/suites/nereids_p0/test_drop_storage_policy_command.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("test_drop_storage_policy_command", "drop,storage_policy") { | ||
| String policyName = "test_drop_storage_policy"; | ||
| String resourceName = "test_drop_storage_policy_resource"; | ||
| try { | ||
| // Drop existing storage policy and resource if they exist before creating new ones | ||
| try_sql("DROP STORAGE POLICY IF EXISTS ${policyName}") | ||
| try_sql("DROP RESOURCE IF EXISTS ${resourceName}") | ||
| // Create a new resource to be used in the storage policy | ||
| sql """ | ||
| CREATE RESOURCE IF NOT EXISTS "${resourceName}" | ||
| PROPERTIES( | ||
| "type"="s3", | ||
| "AWS_ENDPOINT" = "${getS3Endpoint()}", | ||
| "AWS_REGION" = "${getS3Region()}", | ||
| "AWS_ROOT_PATH" = "regression/cooldown", | ||
| "AWS_ACCESS_KEY" = "${getS3AK()}", | ||
| "AWS_SECRET_KEY" = "${getS3SK()}", | ||
| "AWS_MAX_CONNECTIONS" = "50", | ||
| "AWS_REQUEST_TIMEOUT_MS" = "3000", | ||
| "AWS_CONNECTION_TIMEOUT_MS" = "1000", | ||
| "AWS_BUCKET" = "${getS3BucketName()}", | ||
| "s3_validity_check" = "false" | ||
| ); | ||
| """ | ||
|
|
||
| // Create a new storage policy to test the SHOW STORAGE POLICY command | ||
| sql """ | ||
| CREATE STORAGE POLICY IF NOT EXISTS ${policyName} | ||
| PROPERTIES( | ||
| "storage_resource" = "${resourceName}", | ||
| "cooldown_ttl" = "300" | ||
| ) | ||
| """ | ||
|
|
||
| checkNereidsExecute("DROP STORAGE POLICY IF EXISTS ${policyName}") | ||
|
|
||
| } catch (Exception e) { | ||
| // Log any exceptions that occur during testing | ||
| log.error("Failed to execute SHOW STORAGE POLICY command", e) | ||
| throw e | ||
| } finally { | ||
| // Clean up by dropping the storage policy and resource if they still exist | ||
| try_sql("DROP STORAGE POLICY IF EXISTS ${policyName}") | ||
| try_sql("DROP RESOURCE IF EXISTS ${resourceName}") | ||
| } | ||
| } |