Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids #42589

Closed
2 of 3 tasks
Tracked by #42600
LiBinfeng-01 opened this issue Oct 28, 2024 · 1 comment · Fixed by #44970
Closed
2 of 3 tasks
Tracked by #42600

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids #42589

LiBinfeng-01 opened this issue Oct 28, 2024 · 1 comment · Fixed by #44970
Assignees
@msridhar78
Labels
area/nereids good first issue java Pull requests that update Java code

Comments

@LiBinfeng-01
Copy link
Collaborator

Search before asking

  • I had searched in the issues and found no similar issues.

Description

CreateWorkloadGroupCommand is supported in legacy planner but not in nereids(new doris fe planner). you need implement it in nereids.
The DorisParser.g4 has the syntax definition already(see bellow). And you can check CreateWorkloadGroupStmt.java in legacy planner to see what the command does and migrate it to nereids planner
CREATE WORKLOAD GROUP (IF NOT EXISTS)? name=identifierOrText properties=propertyClause?

Solution

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@LiBinfeng-01 LiBinfeng-01 mentioned this issue Oct 28, 2024
Open
16 tasks
@starocean999 starocean999 added good first issue java Pull requests that update Java code area/nereids labels Oct 30, 2024
@msridhar78
Copy link
Contributor

@starocean999 @LiBinfeng-01 I will pick this up

@msridhar78 msridhar78 mentioned this issue Dec 4, 2024
Merged
16 tasks
starocean999 pushed a commit that referenced this issue Dec 9, 2024
@msridhar78
[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids (
9c4c0b3 
#44970)

Issue Number: close #42589
@github-project-automation github-project-automation bot moved this from In review to Done in impl all command in Nereids Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msridhar78 msridhar78

Labels
area/nereids good first issue java Pull requests that update Java code
Projects
impl all command in Nereids
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids msridhar78/doris
3 participants
@starocean999 @LiBinfeng-01 @msridhar78