Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids #44970

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

msridhar78
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42589

Related PR: #xxx

Problem Summary:

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor

run buildall

@LiBinfeng-01
Copy link
Collaborator

it seems like implementation has some problem in cases

@msridhar78 msridhar78 force-pushed the create_workload_group branch from 5501a46 to 138f5e0 Compare December 4, 2024 13:20
@msridhar78
Copy link
Contributor Author

it seems like implementation has some problem in cases

Fixed the issue - stripQuotes was missing for workload name

@msridhar78
Copy link
Contributor Author

run buildall

@msridhar78
Copy link
Contributor Author

run P0

1 similar comment
@msridhar78
Copy link
Contributor Author

run P0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 9c4c0b3 into apache:master Dec 9, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement CreateWorkloadGroupCommand in nereids
4 participants