[regression-test](fix) fix case with invalid grammer #45211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
shuke987
requested review from
dataroaring,
morningman and
924060929
and removed request for
dataroaring
924060929
approved these changes
Dec 11, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
16 tasks
hello-stephen
pushed a commit
that referenced
this pull request
Dec 12, 2024
### What problem does this PR solve? fix `test_partial_update_2pc_schema_change` and `test_f_2pc_schema_change` case due to changes in #45211
shuke987
pushed a commit
to shuke987/doris
that referenced
this pull request
Dec 23, 2024
fix `test_partial_update_2pc_schema_change` and `test_f_2pc_schema_change` case due to changes in apache#45211
shuke987
added a commit
to shuke987/doris
that referenced
this pull request
Dec 23, 2024
Problem Summary: Defining global variables in a test suite can easily introduce errors, such as variable conflicts in concurrent scenarios. In apache#44576 , a method for detecting global variables was introduced. That approach conflicts with the function calling like connect(user=user, password="pwd"). Furthermore, the connect(user=user, password="pwd") method cannot specify assignments to parameters with default values; values still need to be assigned according to the order of parameters. Therefore, modifying these calling method.
shuke987
added a commit
to shuke987/doris
that referenced
this pull request
Dec 23, 2024
Problem Summary: Defining global variables in a test suite can easily introduce errors, such as variable conflicts in concurrent scenarios. In apache#44576 , a method for detecting global variables was introduced. That approach conflicts with the function calling like connect(user=user, password="pwd"). Furthermore, the connect(user=user, password="pwd") method cannot specify assignments to parameters with default values; values still need to be assigned according to the order of parameters. Therefore, modifying these calling method.
shuke987
pushed a commit
to shuke987/doris
that referenced
this pull request
Dec 23, 2024
### What problem does this PR solve? fix `test_partial_update_2pc_schema_change` and `test_f_2pc_schema_change` case due to changes in apache#45211
dataroaring
pushed a commit
that referenced
this pull request
Dec 24, 2024
Problem Summary: Defining global variables in a test suite can easily introduce errors, such as variable conflicts in concurrent scenarios. In #44576 , a method for detecting global variables was introduced. That approach conflicts with the function calling like connect(user=user, password="pwd"). Furthermore, the connect(user=user, password="pwd") method cannot specify assignments to parameters with default values; values still need to be assigned according to the order of parameters. Therefore, modifying these calling method. Co-authored-by: bobhan1 <[email protected]>
yiguolei
pushed a commit
that referenced
this pull request
Dec 24, 2024
Problem Summary: Defining global variables in a test suite can easily introduce errors, such as variable conflicts in concurrent scenarios. In #44576 , a method for detecting global variables was introduced. That approach conflicts with the function calling like connect(user=user, password="pwd"). Furthermore, the connect(user=user, password="pwd") method cannot specify assignments to parameters with default values; values still need to be assigned according to the order of parameters. Therefore, modifying these calling method.
shuke987
added
dev/3.0.4-merged
and removed
dev/3.0.x-conflict
dev/2.1.x-conflict
dev/3.0.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Defining global variables in a test suite can easily introduce errors, such as variable conflicts in concurrent scenarios.
In #44576 , a method for detecting global variables was introduced.
That approach conflicts with the function calling like connect(user=user, password="pwd"). Furthermore, the connect(user=user, password="pwd") method cannot specify assignments to parameters with default values; values still need to be assigned according to the order of parameters. Therefore, modifying these calling method.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)