Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression) Fix some p0 case #45333

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[fix](regression) Fix some p0 case #45333

merged 1 commit into from
Dec 12, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 12, 2024 •
edited
Loading

What problem does this PR solve?

fix test_partial_update_2pc_schema_change and test_f_2pc_schema_change case due to changes in #45211

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 12, 2024

run buildall

zhannngchen
zhannngchen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 12, 2024

run p0

hello-stephen
hello-stephen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen hello-stephen merged commit 069a33a into apache:master Dec 12, 2024
32 of 34 checks passed
shuke987 pushed a commit to shuke987/doris that referenced this pull request Dec 23, 2024
@bobhan1 @shuke987
[fix](regression) Fix some p0 case (apache#45333)
90df044 
fix `test_partial_update_2pc_schema_change` and
`test_f_2pc_schema_change` case due to changes in
apache#45211
shuke987 pushed a commit to shuke987/doris that referenced this pull request Dec 23, 2024
@bobhan1 @shuke987
[fix](regression) Fix some p0 case (apache#45333)
3be7eb4 
### What problem does this PR solve?


fix `test_partial_update_2pc_schema_change` and
`test_f_2pc_schema_change` case due to changes in
apache#45211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobhan1 @hello-stephen @zhannngchen