[fix](inverted index) fix the issue where need_read_data does not handle non-pushdown conditions #36292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39950 ms |
TPC-DS: Total hot run time: 170569 ms |
ClickBench: Total hot run time: 31.12 s |
zzzxl1993
force-pushed
the
need_read_data_opt_fix
branch
from
75570c3 to
28dc01a
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39402 ms |
TPC-DS: Total hot run time: 170570 ms |
ClickBench: Total hot run time: 31.35 s |
zzzxl1993
force-pushed
the
need_read_data_opt_fix
branch
from
28dc01a to
9c0450b
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40832 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172024 ms |
ClickBench: Total hot run time: 30.43 s |
zzzxl1993
force-pushed
the
need_read_data_opt_fix
branch
from
9c0450b to
a94a7f6
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39923 ms |
TPC-DS: Total hot run time: 170624 ms |
ClickBench: Total hot run time: 31.03 s |
TPC-H: Total hot run time: 40618 ms |
TPC-DS: Total hot run time: 174468 ms |
ClickBench: Total hot run time: 30.9 s |
xiaokang
changed the title
xiaokang
reviewed
Jun 16, 2024
| if (!_check_apply_by_inverted_index(pred)) { | ||
| continue; | ||
| } | ||
| push_down_preds.insert(_gen_predicate_result_sign(pred)); |
There was a problem hiding this comment.
Pred may not be evaluated by index even if _check_apply_by_inverted_index(pred) return true due to skip index based on hit ratio. So push_down_preds.contains(column_sign) can not guarantee that the pred for column_sing can be skipped.
There was a problem hiding this comment.
This section only calculates which conditions definitely require data reading, the conditions that do not require data reading are computed in other logical calculations.
| @@ -984,7 +1012,7 @@ std::string SegmentIterator::_gen_predicate_result_sign(ColumnPredicate* predica | |||
|
|
|||
| std::string col_name = column_desc->name(); | |||
|
|
|||
| if (column_desc->path() != nullptr) { | |||
| if (column_desc->path() != nullptr && !_storage_name_and_type.empty()) { | |||
|
PR approved by anyone and no changes requested. |
qidaye
approved these changes
Jun 17, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
This was referenced Jun 18, 2024
xiaokang
pushed a commit
that referenced
this pull request
Jun 20, 2024
xiaokang
added
dev/2.1.4-merged
dev/2.0.12-merged
and removed
dev/2.0.12-merged
dev/2.1.x
labels
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…dle non-pushdown conditions apache#36292 (apache#36491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dle non-pushdown conditions
Proposed changes