Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0](cherry-pick) update some CHECK to CHECK_EQ, to print more details while CHECK failed (#33709) #36323

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

cherry-pick #33709

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8096/21411)
Line Coverage: 29.47% (66149/224444)
Region Coverage: 28.95% (34101/117813)
Branch Coverage: 24.81% (17504/70548)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cb516b703c973f56189566eb4b4ce6004921be5c_cb516b703c973f56189566eb4b4ce6004921be5c/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49698 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cb516b703c973f56189566eb4b4ce6004921be5c, data reload: false

------ Round 1 ----------------------------------
q1	17850	4426	4343	4343
q2	2093	154	146	146
q3	10517	1914	1910	1910
q4	10334	1253	1317	1253
q5	8482	3911	3880	3880
q6	255	127	144	127
q7	2015	1616	1614	1614
q8	9503	2717	2714	2714
q9	13988	10381	10179	10179
q10	8621	3557	3517	3517
q11	408	247	249	247
q12	476	307	307	307
q13	18360	3985	4021	3985
q14	357	326	329	326
q15	512	467	467	467
q16	661	574	567	567
q17	1121	925	887	887
q18	7292	6810	6915	6810
q19	1779	1639	1638	1638
q20	546	312	301	301
q21	4474	4075	4039	4039
q22	530	453	441	441
Total cold run time: 120174 ms
Total hot run time: 49698 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4338	4340	4337	4337
q2	327	233	221	221
q3	4167	4169	4140	4140
q4	2747	2734	2743	2734
q5	7165	7064	7085	7064
q6	238	120	119	119
q7	3257	2851	2808	2808
q8	4345	4490	4471	4471
q9	16942	16710	16663	16663
q10	4216	4296	4260	4260
q11	756	681	707	681
q12	1014	860	861	860
q13	7133	3765	3757	3757
q14	443	435	417	417
q15	511	459	462	459
q16	737	695	702	695
q17	3871	3873	3919	3873
q18	8849	8688	8815	8688
q19	1727	1659	1669	1659
q20	2395	2114	2093	2093
q21	8426	8507	8533	8507
q22	1058	988	963	963
Total cold run time: 84662 ms
Total hot run time: 79469 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204024 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb516b703c973f56189566eb4b4ce6004921be5c, data reload: false

query1	929	420	381	381
query2	6543	2855	2610	2610
query3	6924	202	200	200
query4	20028	18098	17994	17994
query5	19743	6540	6551	6540
query6	283	215	228	215
query7	4166	311	331	311
query8	430	422	430	422
query9	3135	2702	2644	2644
query10	421	300	297	297
query11	11398	10757	10848	10757
query12	139	76	76	76
query13	5588	701	697	697
query14	17524	13180	13770	13180
query15	369	244	250	244
query16	6480	287	274	274
query17	1737	1465	895	895
query18	2301	428	417	417
query19	212	152	153	152
query20	77	81	80	80
query21	187	104	101	101
query22	5251	4977	4927	4927
query23	32757	31792	32004	31792
query24	7041	6509	6539	6509
query25	526	431	430	430
query26	540	166	171	166
query27	1866	299	298	298
query28	6158	2368	2329	2329
query29	2907	2737	2899	2737
query30	253	169	174	169
query31	921	722	765	722
query32	71	66	62	62
query33	403	270	268	268
query34	848	461	495	461
query35	1138	931	927	927
query36	1226	1123	1336	1123
query37	97	61	61	61
query38	3058	2909	2957	2909
query39	1399	1323	1326	1323
query40	209	101	97	97
query41	46	44	43	43
query42	88	79	82	79
query43	824	720	613	613
query44	1178	726	710	710
query45	257	237	245	237
query46	1226	978	961	961
query47	1740	1813	1840	1813
query48	1035	734	722	722
query49	625	382	362	362
query50	853	608	588	588
query51	4797	4701	4742	4701
query52	85	84	74	74
query53	446	333	323	323
query54	2704	2461	2513	2461
query55	98	82	89	82
query56	248	215	215	215
query57	1227	1181	1250	1181
query58	225	200	208	200
query59	4226	4061	4048	4048
query60	218	213	228	213
query61	97	96	97	96
query62	830	455	476	455
query63	498	346	355	346
query64	2397	1553	1486	1486
query65	3662	3557	3574	3557
query66	836	392	387	387
query67	16617	15456	16348	15456
query68	8495	649	662	649
query69	562	343	373	343
query70	1668	1411	1303	1303
query71	395	310	314	310
query72	6541	3479	3482	3479
query73	741	322	325	322
query74	6369	5877	5890	5877
query75	5054	3703	3695	3695
query76	5027	1151	1171	1151
query77	837	263	253	253
query78	12551	11673	12776	11673
query79	11453	658	635	635
query80	1104	404	401	401
query81	486	232	232	232
query82	1454	100	102	100
query83	175	136	137	136
query84	263	70	70	70
query85	879	324	318	318
query86	321	301	287	287
query87	3193	3002	3046	3002
query88	5010	2349	2338	2338
query89	482	293	305	293
query90	1940	218	211	211
query91	190	143	142	142
query92	62	55	54	54
query93	6174	582	566	566
query94	723	214	214	214
query95	1125	1048	1057	1048
query96	650	329	338	329
query97	6423	6394	6377	6377
query98	199	180	175	175
query99	2620	852	835	835
Total cold run time: 315532 ms
Total hot run time: 204024 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cb516b703c973f56189566eb4b4ce6004921be5c, data reload: false

query1	0.02	0.02	0.02
query2	0.08	0.02	0.02
query3	0.25	0.05	0.04
query4	1.79	0.11	0.07
query5	0.54	0.53	0.53
query6	1.30	0.63	0.63
query7	0.02	0.01	0.01
query8	0.04	0.02	0.03
query9	0.52	0.48	0.49
query10	0.53	0.52	0.54
query11	0.12	0.09	0.09
query12	0.11	0.10	0.09
query13	0.63	0.61	0.62
query14	0.77	0.79	0.78
query15	0.78	0.76	0.76
query16	0.35	0.35	0.38
query17	0.99	1.01	1.01
query18	0.21	0.25	0.25
query19	1.93	1.88	1.81
query20	0.02	0.01	0.01
query21	15.46	0.54	0.55
query22	2.51	2.53	1.18
query23	16.95	1.15	0.95
query24	4.64	2.32	2.47
query25	0.36	0.14	0.04
query26	0.72	0.16	0.15
query27	0.04	0.04	0.04
query28	5.97	0.75	0.73
query29	12.62	2.36	2.12
query30	0.58	0.55	0.52
query31	2.81	0.38	0.38
query32	3.37	0.49	0.49
query33	3.06	3.10	3.06
query34	15.27	4.78	4.81
query35	4.86	4.86	4.82
query36	1.05	1.02	1.03
query37	0.06	0.04	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.15
query41	0.07	0.02	0.01
query42	0.02	0.02	0.02
query43	0.03	0.02	0.01
Total cold run time: 101.67 s
Total hot run time: 31.49 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit cb516b703c973f56189566eb4b4ce6004921be5c with default session variables
Stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.5 seconds inserted 10000000 Rows, about 465K ops/s

@zhannngchen zhannngchen merged commit 02d0ef8 into apache:branch-2.0 Jun 14, 2024
22 of 25 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants