Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[performance](move-memtable) async close tablet streams #41156

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[performance](move-memtable) async close tablet streams #41156

merged 1 commit into from
Nov 11, 2024

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Sep 23, 2024 •
edited
Loading

Proposed changes

Asynchronously close tablet streams to speed up load stream close.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9609/25776)
Line Coverage: 28.68% (79500/277176)
Region Coverage: 28.14% (41135/146199)
Branch Coverage: 24.78% (20969/84630)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b141e407e28fb4ed6fd938867df74641709f9ebc_b141e407e28fb4ed6fd938867df74641709f9ebc/report/index.html

@kaijchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9628/25817)
Line Coverage: 28.69% (79691/277745)
Region Coverage: 28.13% (41220/146538)
Branch Coverage: 24.74% (20983/84816)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ad329fa5e7ca268f9697c6f9848ff647ade78241_ad329fa5e7ca268f9697c6f9848ff647ade78241/report/index.html

@kaijchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9627/25817)
Line Coverage: 28.69% (79677/277764)
Region Coverage: 28.12% (41212/146542)
Branch Coverage: 24.74% (20985/84818)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0396fa762a7da94a5092982bd09f49f42a40b078_0396fa762a7da94a5092982bd09f49f42a40b078/report/index.html

@kaijchen kaijchen marked this pull request as ready for review September 30, 2024 02:10
@liaoxin01
Copy link
Contributor

All tablet close operations should be handled by a single thread to avoid saturating the heavy_work thread pool when there are many tablets.

@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@liaoxin01
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.92% (9872/26033)
Line Coverage: 29.09% (82275/282782)
Region Coverage: 28.24% (42346/149936)
Branch Coverage: 24.79% (21442/86488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/760c9d43757c631a862a9b27d6f8fb9f3b256b79_760c9d43757c631a862a9b27d6f8fb9f3b256b79/report/index.html

liaoxin01
liaoxin01 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b00a107 into apache:master Nov 11, 2024
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (#41156)
9362449 
## Proposed changes

Asynchronously close tablet streams to speed up load stream close.
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Closed
kaijchen added a commit to kaijchen/doris that referenced this pull request Nov 18, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (apache#41156)
06d6ee0 
Asynchronously close tablet streams to speed up load stream close.
@kaijchen kaijchen mentioned this pull request Nov 18, 2024
Merged
kaijchen added a commit to kaijchen/doris that referenced this pull request Nov 18, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (apache#41156)
138d4a3 
Asynchronously close tablet streams to speed up load stream close.
dataroaring pushed a commit that referenced this pull request Nov 19, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (#41156 & #43813
b4e136b 
) (#44128)

backport #41156 and #43813
kaijchen added a commit to kaijchen/doris that referenced this pull request Nov 22, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (apache#41156)
b253e59 
## Proposed changes

Asynchronously close tablet streams to speed up load stream close.
@kaijchen kaijchen mentioned this pull request Nov 22, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@kaijchen
[performance](move-memtable) async close tablet streams (#41156 & #43813
a565672 
) (#44471)

backport #41156 and #43813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaijchen @doris-robot @liaoxin01 @dataroaring