[improve](column) implement insert_many_from function for all column #41623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40942 ms |
TPC-DS: Total hot run time: 192305 ms |
ClickBench: Total hot run time: 32.8 s |
|
run buildall |
1 similar comment
|
run buildall |
HappenLee
reviewed
Oct 10, 2024
HappenLee
reviewed
Oct 10, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41288 ms |
TPC-DS: Total hot run time: 192453 ms |
ClickBench: Total hot run time: 33.6 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Oct 12, 2024
qzsee
pushed a commit
to qzsee/incubator-doris
that referenced
this pull request
Oct 16, 2024
…pache#41623) ## Proposed changes the cross join will call insert_many_from function to combine left table column as result, implement it's will reduce much virtual function call. ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (5.56 sec) ``` ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (3.29 sec) ``` <!--Describe your changes.-->
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Nov 21, 2024
…pache#41623) ## Proposed changes the cross join will call insert_many_from function to combine left table column as result, implement it's will reduce much virtual function call. ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (5.56 sec) ``` ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (3.29 sec) ``` <!--Describe your changes.-->
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Nov 21, 2024
…pache#41623) ## Proposed changes the cross join will call insert_many_from function to combine left table column as result, implement it's will reduce much virtual function call. ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (5.56 sec) ``` ``` mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t; +------------------+ | count(c_custkey) | +------------------+ | 7668000000 | +------------------+ 1 row in set (3.29 sec) ``` <!--Describe your changes.-->
zhangstar333
added a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
the cross join will call insert_many_from function to combine left table column as result,
implement it's will reduce much virtual function call.