[Fix](build) fix cloud compilation on arm (mac_osx) without libs2n.a #41773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
gavinchou
changed the title
gavinchou
previously approved these changes
Oct 13, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Oct 13, 2024
| @@ -88,7 +88,9 @@ add_thirdparty(aws-c-mqtt LIB64) | |||
| add_thirdparty(aws-checksums LIB64) | |||
| add_thirdparty(aws-c-s3 LIB64) | |||
| add_thirdparty(aws-c-sdkutils LIB64) | |||
| add_thirdparty(aws-s2n LIBNAME "lib/libs2n.a") | |||
| if (NOT OS_MACOSX) | |||
There was a problem hiding this comment.
link may still not work for mac due to there is no arm version of fdb for now
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
reference be/cmake/thirdparty.cmake