[Enhancement] (nereids)implement showSqlBlockRuleCommand in nereids #42979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
morrySnow
requested review from
starocean999 and
morrySnow
and removed request for
morrySnow
TPC-H: Total hot run time: 41433 ms |
TPC-DS: Total hot run time: 196780 ms |
ClickBench: Total hot run time: 31.98 s |
| } | ||
| ShowSqlBlockRuleStmt showStmt = new ShowSqlBlockRuleStmt(ruleName); | ||
| List<List<String>> rows = Lists.newArrayList(); | ||
| List<SqlBlockRule> sqlBlockRules = Env.getCurrentEnv().getSqlBlockRuleMgr().getSqlBlockRule(showStmt); |
There was a problem hiding this comment.
pls add a new getSqlBlockRule function without dependence of ShowSqlBlockRuleStmt
Vallishp
force-pushed
the
nereids_sql_block_rule
branch
from
8e783db to
e4a730a
Compare
|
run buildall |
TPC-H: Total hot run time: 41360 ms |
TPC-DS: Total hot run time: 195637 ms |
ClickBench: Total hot run time: 31.24 s |
|
run p0 |
|
run external |
|
run buildall |
TPC-H: Total hot run time: 40886 ms |
TPC-DS: Total hot run time: 195818 ms |
ClickBench: Total hot run time: 32.66 s |
Vallishp
force-pushed
the
nereids_sql_block_rule
branch
from
3ff2c07 to
974cdf5
Compare
| /** | ||
| * Get SqlBlockRule by show command. | ||
| **/ | ||
| public List<SqlBlockRule> getSqlBlockRule(ShowSqlBlockRuleCommand cmd) throws AnalysisException { |
There was a problem hiding this comment.
better to use String as parameter and change the old code to call the new function to remove duplicate code
Suggested change
| public List<SqlBlockRule> getSqlBlockRule(ShowSqlBlockRuleCommand cmd) throws AnalysisException { | |
| public List<SqlBlockRule> getSqlBlockRule(String ruleName) throws AnalysisException { |
Vallishp
force-pushed
the
nereids_sql_block_rule
branch
from
974cdf5 to
80dd59a
Compare
|
run buildall |
|
run p0 |
2 similar comments
|
run p0 |
|
run p0 |
|
run buildall |
Vallishp
force-pushed
the
nereids_sql_block_rule
branch
from
5f9049a to
b2d9d17
Compare
|
run buildall |
|
run p0 |
Vallishp
force-pushed
the
nereids_sql_block_rule
branch
from
b2d9d17 to
70a6d5e
Compare
|
run buildall |
|
run buildall |
starocean999
approved these changes
Nov 18, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
LiBinfeng-01
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #42719
implement showSqlBlockRuleCommand in nereids