Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement showPluginsCommand in nereids #43131

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[Enhancement] (nereids)implement showPluginsCommand in nereids #43131

merged 1 commit into from
Nov 18, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Nov 2, 2024

What problem does this PR solve?

implement show plugins in nereids

Issue Number: close #42733

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test already exist.
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

mysql> show plugins\G
*************************** 1. row ***************************
Name: __builtin_AuditLoader
Type: AUDIT
Description: builtin audit loader, to load audit log to internal table
Version: 2.1.0
JavaVersion: 1.8.31
ClassName: org.apache.doris.plugin.audit.AuditLoader
SoName: NULL
Sources: Builtin
Status: INSTALLED
Properties: {}
*************************** 2. row ***************************
Name: __builtin_AuditLogBuilder
Type: AUDIT
Description: builtin audit logger
Version: 0.12.0
JavaVersion: 1.8.31
ClassName: org.apache.doris.plugin.audit.AuditLogBuilder
SoName: NULL
Sources: Builtin
Status: INSTALLED
Properties: {}
*************************** 3. row ***************************
Name: __builtin_SqlDialectConverter
Type: DIALECT
Description: builtin sql dialect converter
Version: 2.1.0
JavaVersion: 1.8.31
ClassName: org.apache.doris.plugin.dialect.HttpDialectConverterPlugin
SoName: NULL
Sources: Builtin
Status: INSTALLED
Properties: {}
3 rows in set (3.17 sec)

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 2, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41236 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9a9444b10ba005a849e0ebe021e00c46424cf4e6, data reload: false

------ Round 1 ----------------------------------
q1	17630	7421	7337	7337
q2	2075	165	156	156
q3	10606	1088	1132	1088
q4	10485	826	868	826
q5	7749	3042	3024	3024
q6	237	150	149	149
q7	1010	610	598	598
q8	9335	1960	2042	1960
q9	6511	6483	6466	6466
q10	7088	2395	2434	2395
q11	460	256	264	256
q12	406	218	213	213
q13	17776	3002	3017	3002
q14	234	213	204	204
q15	569	526	512	512
q16	663	596	590	590
q17	970	553	542	542
q18	7201	6687	6633	6633
q19	1347	1052	968	968
q20	488	185	183	183
q21	3926	3162	3129	3129
q22	1116	1017	1005	1005
Total cold run time: 107882 ms
Total hot run time: 41236 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7365	7303	7300	7300
q2	325	225	223	223
q3	2968	2937	2980	2937
q4	2117	1879	1818	1818
q5	5768	5778	5798	5778
q6	224	143	141	141
q7	2243	1833	1811	1811
q8	3375	3546	3475	3475
q9	8904	8955	8861	8861
q10	3578	3547	3601	3547
q11	623	503	502	502
q12	848	663	613	613
q13	10764	3181	3192	3181
q14	296	276	276	276
q15	578	513	534	513
q16	692	642	635	635
q17	1863	1641	1644	1641
q18	8285	7767	7761	7761
q19	1707	1582	1512	1512
q20	2067	1884	1881	1881
q21	5480	5411	5554	5411
q22	1159	1049	1042	1042
Total cold run time: 71229 ms
Total hot run time: 60859 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196540 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9a9444b10ba005a849e0ebe021e00c46424cf4e6, data reload: false

query1	1192	936	933	933
query2	6252	2231	2148	2148
query3	10807	3977	3953	3953
query4	67713	27584	23743	23743
query5	4908	456	439	439
query6	391	178	174	174
query7	5493	293	295	293
query8	308	227	220	220
query9	8699	2772	2756	2756
query10	448	259	247	247
query11	17033	15360	16116	15360
query12	148	104	109	104
query13	1465	426	470	426
query14	10534	6961	6844	6844
query15	217	183	187	183
query16	6721	465	456	456
query17	1012	563	574	563
query18	1716	300	292	292
query19	195	154	148	148
query20	118	110	112	110
query21	200	100	99	99
query22	4659	4410	4377	4377
query23	34544	34040	34268	34040
query24	5947	2736	2749	2736
query25	479	377	398	377
query26	660	149	151	149
query27	1669	279	283	279
query28	4299	2427	2408	2408
query29	664	399	406	399
query30	231	153	149	149
query31	961	791	803	791
query32	65	54	56	54
query33	443	262	262	262
query34	912	498	521	498
query35	827	740	739	739
query36	1084	929	947	929
query37	118	78	68	68
query38	4353	4308	4359	4308
query39	1489	1447	1443	1443
query40	197	92	94	92
query41	44	42	42	42
query42	107	97	96	96
query43	538	499	496	496
query44	1150	815	812	812
query45	183	161	174	161
query46	1116	690	702	690
query47	1934	1852	1895	1852
query48	408	318	311	311
query49	721	398	378	378
query50	796	386	389	386
query51	7270	7078	7130	7078
query52	99	85	87	85
query53	251	184	177	177
query54	523	406	397	397
query55	79	74	74	74
query56	246	230	233	230
query57	1284	1179	1137	1137
query58	208	204	202	202
query59	3337	3205	2969	2969
query60	280	242	238	238
query61	104	101	102	101
query62	773	670	659	659
query63	215	187	187	187
query64	1334	621	619	619
query65	3289	3208	3213	3208
query66	730	288	306	288
query67	15923	15694	15635	15635
query68	2614	575	583	575
query69	412	263	259	259
query70	1207	1124	1158	1124
query71	331	250	252	250
query72	5353	4195	4188	4188
query73	760	358	357	357
query74	9697	9076	9066	9066
query75	3420	2647	2661	2647
query76	1451	1051	1035	1035
query77	431	287	265	265
query78	10207	9491	9516	9491
query79	1902	585	590	585
query80	1248	418	438	418
query81	546	236	242	236
query82	525	111	120	111
query83	156	137	135	135
query84	276	67	70	67
query85	974	298	280	280
query86	378	300	294	294
query87	4950	4742	4817	4742
query88	3787	2195	2149	2149
query89	414	292	285	285
query90	1967	184	182	182
query91	131	99	103	99
query92	64	49	46	46
query93	2469	535	533	533
query94	893	294	293	293
query95	359	254	245	245
query96	627	278	286	278
query97	2864	2706	2733	2706
query98	204	199	195	195
query99	1592	1344	1307	1307
Total cold run time: 314322 ms
Total hot run time: 196540 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9a9444b10ba005a849e0ebe021e00c46424cf4e6, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.11
query5	0.41	0.38	0.41
query6	1.14	0.65	0.65
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.51
query10	0.55	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.12	0.12
query13	0.62	0.60	0.60
query14	2.70	2.81	2.71
query15	0.90	0.83	0.84
query16	0.38	0.39	0.40
query17	1.11	1.09	1.02
query18	0.19	0.20	0.20
query19	1.94	1.93	2.02
query20	0.02	0.01	0.01
query21	15.37	0.58	0.58
query22	2.42	2.76	1.84
query23	16.83	1.04	0.84
query24	3.20	1.28	1.26
query25	0.26	0.08	0.06
query26	0.54	0.14	0.14
query27	0.04	0.04	0.05
query28	10.06	1.10	1.07
query29	12.56	3.23	3.22
query30	0.25	0.06	0.05
query31	2.88	0.38	0.37
query32	3.28	0.45	0.46
query33	2.99	3.06	2.97
query34	17.28	4.51	4.44
query35	4.45	4.46	4.47
query36	0.67	0.49	0.48
query37	0.09	0.05	0.05
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.41 s
Total hot run time: 32.81 s

@starocean999
Copy link
Contributor

please resolve conflicts

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

1 similar comment
@Vallishp
Copy link
Contributor Author

run buildall

starocean999
starocean999 reviewed Nov 18, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowPluginsCommand.java Outdated
* show plugins command
*/
public class ShowPluginsCommand extends ShowCommand {
public static final Logger LOG = LogManager.getLogger(ShowPluginsCommand.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final Logger LOG = LogManager.getLogger(ShowPluginsCommand.class);

starocean999
starocean999 previously approved these changes Nov 18, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Vallishp
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@starocean999 starocean999 merged commit 5a1959d into apache:master Nov 18, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showPluginsCommand in nereids
4 participants
@Vallishp @doris-robot @starocean999 @LiBinfeng-01