-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat](nereids) support ShowTabletStorageFormat command in nereids #43295
[Feat](nereids) support ShowTabletStorageFormat command in nereids #43295
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
a1fb1da
to
f3729c0
Compare
run buildall |
TPC-H: Total hot run time: 41191 ms
|
TPC-DS: Total hot run time: 197783 ms
|
if (result == null) { | ||
throw new AnalysisException("get tablet data from backend: " + be.getId() + "error."); | ||
} | ||
if (isVerbose()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove isVerbose() function, access verbose member directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@Override | ||
public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN) | ||
&& !Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.OPERATOR)
is not in ShowTabletStorageFormatStmt's analyze() method, why need it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the check. Thanks for pointing it out. Since this is admin only, the operator should not be allowed.
/** | ||
* admin show tablet storage format command | ||
*/ | ||
public class ShowTabletStorageFormatCommand extends Command implements NoForward { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new method checkSupportedInCloudMode()
is added in Command.java by https://github.com/apache/doris/pull/43271/files, ShowTabletStorageFormatCommand need implement it with same logic like ShowTabletStorageFormatStmt, please update after the pr is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Update after the PR is merged.
*/ | ||
public class ShowTabletStorageFormatCommand extends Command implements NoForward { | ||
public static final Logger LOG = LogManager.getLogger(ShowTabletStorageFormatCommand.class); | ||
private boolean verbose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private boolean verbose; | |
private final boolean verbose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
c36ee4b
to
53323be
Compare
run buildall |
TPC-H: Total hot run time: 41189 ms
|
TPC-DS: Total hot run time: 196541 ms
|
ClickBench: Total hot run time: 32.84 s
|
pr's related issue is |
please rebase latest master and resolve the conflicts |
53323be
to
b2c1ca3
Compare
1321101
to
730a7ce
Compare
730a7ce
to
1a4c1b9
Compare
run buildall |
PR approved by anyone and no changes requested. |
c201770
to
a75528a
Compare
run buildall |
TPC-H: Total hot run time: 40271 ms
|
TPC-DS: Total hot run time: 191137 ms
|
ClickBench: Total hot run time: 31.99 s
|
a75528a
to
abae223
Compare
run buildall |
TPC-H: Total hot run time: 40380 ms
|
TPC-DS: Total hot run time: 190820 ms
|
ClickBench: Total hot run time: 31.93 s
|
run doris_compile |
run buildall |
TPC-H: Total hot run time: 39667 ms
|
TPC-DS: Total hot run time: 197033 ms
|
ClickBench: Total hot run time: 32.22 s
|
115dd25
to
1c51a0f
Compare
run buildall |
TPC-H: Total hot run time: 40065 ms
|
TPC-DS: Total hot run time: 198371 ms
|
ClickBench: Total hot run time: 32.15 s
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #42783
Related PR: #xxx
Problem Summary:
Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)