Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](inverted index) fix error handling in fast_execute (#40024) #43393

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

zzzxl1993
Copy link
Contributor

pick #40024

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Nov 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49805 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7f8571240bb5710b361583f6808f41a7f99a3bb, data reload: false

------ Round 1 ----------------------------------
q1	18201	4421	4425	4421
q2	2082	160	146	146
q3	10262	1935	1934	1934
q4	10109	1317	1374	1317
q5	8583	4335	3966	3966
q6	231	123	127	123
q7	2032	1642	1598	1598
q8	9273	2792	2816	2792
q9	10836	10107	10052	10052
q10	8701	3612	3556	3556
q11	424	256	262	256
q12	471	296	302	296
q13	18394	3974	4036	3974
q14	355	331	340	331
q15	518	463	453	453
q16	542	454	458	454
q17	1154	984	970	970
q18	7217	6842	6792	6792
q19	1690	1590	1571	1571
q20	531	298	311	298
q21	4515	4201	4117	4117
q22	507	388	389	388
Total cold run time: 116628 ms
Total hot run time: 49805 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4380	4315	4371	4315
q2	326	231	222	222
q3	4219	4216	4178	4178
q4	2764	2761	2779	2761
q5	7281	7218	7185	7185
q6	240	118	117	117
q7	3245	2832	2874	2832
q8	4410	4474	4510	4474
q9	14353	14003	14105	14003
q10	4378	4268	4276	4268
q11	725	695	712	695
q12	1025	867	896	867
q13	7281	3742	3750	3742
q14	456	436	429	429
q15	502	476	456	456
q16	651	596	600	596
q17	3747	3894	3820	3820
q18	8809	8785	8791	8785
q19	1737	1711	1708	1708
q20	2383	2129	2105	2105
q21	8438	8439	8465	8439
q22	1071	953	930	930
Total cold run time: 82421 ms
Total hot run time: 76927 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.54% (8307/21553)
Line Coverage: 30.24% (68672/227068)
Region Coverage: 29.67% (35369/119204)
Branch Coverage: 25.44% (18190/71502)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d7f8571240bb5710b361583f6808f41a7f99a3bb_d7f8571240bb5710b361583f6808f41a7f99a3bb/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 212444 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7f8571240bb5710b361583f6808f41a7f99a3bb, data reload: false

query1	922	434	385	385
query2	6553	2293	2148	2148
query3	6927	204	198	198
query4	23184	21631	21650	21631
query5	19749	6520	6504	6504
query6	282	216	228	216
query7	4341	294	306	294
query8	270	256	245	245
query9	3066	2638	2546	2546
query10	465	317	310	310
query11	15866	14893	14999	14893
query12	136	80	73	73
query13	1038	463	433	433
query14	17366	13384	13562	13384
query15	379	224	226	224
query16	6480	296	274	274
query17	1688	936	916	916
query18	885	315	322	315
query19	206	148	147	147
query20	105	114	100	100
query21	193	110	94	94
query22	5236	5099	4966	4966
query23	34108	33532	33605	33532
query24	7022	6399	6349	6349
query25	541	442	436	436
query26	806	164	155	155
query27	2309	301	286	286
query28	6086	2261	2222	2222
query29	2842	2844	2849	2844
query30	249	172	165	165
query31	967	725	770	725
query32	73	63	62	62
query33	442	259	266	259
query34	847	491	467	467
query35	1146	916	877	877
query36	1407	1193	1333	1193
query37	93	61	61	61
query38	3069	2928	2883	2883
query39	1384	1317	1329	1317
query40	210	95	98	95
query41	40	39	38	38
query42	87	87	77	77
query43	605	558	622	558
query44	1162	731	720	720
query45	243	232	231	231
query46	1232	952	984	952
query47	1975	1904	1863	1863
query48	524	397	405	397
query49	626	370	396	370
query50	855	634	647	634
query51	4848	4680	4652	4652
query52	96	82	98	82
query53	230	181	193	181
query54	2691	2445	2493	2445
query55	85	87	84	84
query56	226	201	219	201
query57	1281	1276	1180	1180
query58	223	221	213	213
query59	3380	3247	3237	3237
query60	223	203	205	203
query61	99	96	101	96
query62	830	445	439	439
query63	206	176	178	176
query64	3272	1528	1513	1513
query65	3639	3552	3519	3519
query66	782	424	412	412
query67	15778	14860	17230	14860
query68	9570	640	638	638
query69	514	272	278	272
query70	1565	1410	1500	1410
query71	414	315	313	313
query72	6935	4956	4880	4880
query73	745	318	321	318
query74	6358	5931	5788	5788
query75	5260	3763	3688	3688
query76	5363	1104	1184	1104
query77	903	256	256	256
query78	12846	11654	11572	11572
query79	7949	635	629	629
query80	1657	413	379	379
query81	489	241	241	241
query82	1644	100	98	98
query83	176	131	130	130
query84	262	71	69	69
query85	906	325	323	323
query86	324	311	289	289
query87	3175	3014	3018	3014
query88	4693	2277	2288	2277
query89	505	277	286	277
query90	1988	209	215	209
query91	165	128	135	128
query92	58	52	53	52
query93	6355	599	585	585
query94	720	212	209	209
query95	2006	2073	2064	2064
query96	645	318	319	318
query97	6568	6335	6453	6335
query98	221	210	214	210
query99	3015	834	812	812
Total cold run time: 318170 ms
Total hot run time: 212444 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.24 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d7f8571240bb5710b361583f6808f41a7f99a3bb, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.02	0.02
query3	0.25	0.05	0.05
query4	1.78	0.07	0.06
query5	0.53	0.51	0.53
query6	1.23	0.61	0.63
query7	0.01	0.02	0.01
query8	0.03	0.02	0.02
query9	0.52	0.49	0.48
query10	0.55	0.55	0.53
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.64	0.61	0.60
query14	0.78	0.78	0.78
query15	0.78	0.76	0.78
query16	0.38	0.37	0.36
query17	1.00	0.98	1.03
query18	0.24	0.24	0.25
query19	1.89	1.85	1.83
query20	0.01	0.01	0.01
query21	15.46	0.57	0.54
query22	1.97	2.07	1.46
query23	16.75	0.97	1.11
query24	7.97	0.64	0.70
query25	0.36	0.08	0.06
query26	0.84	0.17	0.15
query27	0.04	0.05	0.05
query28	5.88	0.78	0.74
query29	12.63	2.32	2.21
query30	0.61	0.54	0.54
query31	2.81	0.37	0.38
query32	3.40	0.50	0.49
query33	3.04	3.06	3.08
query34	15.27	4.81	4.81
query35	4.86	4.84	4.84
query36	1.04	1.02	1.01
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.02
query40	0.16	0.14	0.15
query41	0.06	0.01	0.02
query42	0.02	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.28 s
Total hot run time: 30.24 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d7f8571240bb5710b361583f6808f41a7f99a3bb with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.6 seconds inserted 10000000 Rows, about 462K ops/s

@zzzxl1993 zzzxl1993 changed the title [fix](inverted index) fix error handling in fast_execute [fix](inverted index) fix error handling in fast_execute #40024 Nov 7, 2024
@zzzxl1993 zzzxl1993 changed the title [fix](inverted index) fix error handling in fast_execute #40024 [fix](inverted index) fix error handling in fast_execute (#40024) Nov 7, 2024
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 2530049 into apache:branch-2.0 Nov 8, 2024
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants