[Chore](runtime-filter) add rpc error msg to RuntimeFilterContext #43517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/exprs/runtime_filter.cpp
Outdated
| using Base = | ||
| AutoReleaseClosure<PSendFilterSizeRequest, DummyBrpcCallback<PSendFilterSizeResponse>>; | ||
| ENABLE_FACTORY_CREATOR(SyncSizeClosure); | ||
|
|
||
| ~SyncSizeClosure() override { ((pipeline::CountedFinishDependency*)_dependency.get())->sub(); } |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~SyncSizeClosure() override { ((pipeline::CountedFinishDependency*)_dependency.get())->sub(); }
^
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
Gabriel39
approved these changes
Nov 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zclllyybb
approved these changes
Nov 11, 2024
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 26, 2024
…3517) add rpc error msg to RuntimeFilterContext
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 26, 2024
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 28, 2024
BiteTheDDDDt
added a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add rpc error msg to RuntimeFilterContext
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)