Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](status) Fix wrong status check in data size check #43545

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[Fix](status) Fix wrong status check in data size check #43545

merged 3 commits into from
Nov 12, 2024

Conversation

Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.91% (9867/26027)
Line Coverage: 29.09% (82263/282773)
Region Coverage: 28.25% (42349/149928)
Branch Coverage: 24.79% (21441/86488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ac2d561f09369a9f3816bf8f3fae522918a264a9_ac2d561f09369a9f3816bf8f3fae522918a264a9/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.91% (9866/26026)
Line Coverage: 29.09% (82241/282748)
Region Coverage: 28.24% (42335/149927)
Branch Coverage: 24.78% (21436/86488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eedf5956924e327c325ffb0b615e422cdac01437_eedf5956924e327c325ffb0b615e422cdac01437/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

run cloud_p0

@Yukang-Lian
Copy link
Collaborator Author

run performance

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou self-requested a review November 12, 2024 02:20
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

TangSiyang2001
TangSiyang2001 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit aea1bd3 into apache:master Nov 12, 2024
26 of 30 checks passed
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Nov 12, 2024
@Yukang-Lian @zzzxl1993
[Fix](status) Fix wrong status check in data size check (apache#43545)
4528289
py023 pushed a commit to py023/doris that referenced this pull request Nov 13, 2024
@Yukang-Lian @py023
[Fix](status) Fix wrong status check in data size check (apache#43545)
7c83ab2
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Nov 17, 2024
@Yukang-Lian
[Fix](status) Fix wrong status check in data size check (apache#43545)
a889227
@Yukang-Lian Yukang-Lian mentioned this pull request Nov 17, 2024
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Nov 17, 2024
@Yukang-Lian
[cherry-pick](branch-3.0) Pick "[Fix](status) Fix wrong status check …
a4406ff 
…in data size check (#43545)" (#44085)

### What problem does this PR solve?

Issue Number: close #xxx

Pick #43545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TangSiyang2001 TangSiyang2001 TangSiyang2001 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yukang-Lian @doris-robot @gavinchou @TangSiyang2001 @dataroaring