Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecosystem](kettle) add delete mode for kettle plugin #43820

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Nov 13, 2024

What problem does this PR solve?

The current Kettle component can only add new data. In some scenarios, it is necessary to delete upstream data, so a delete option is added.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (Currently, kettle plugin does not have automatic testing, which will be added later)
      1. mvn clean package -DskipTests to compile plugin
      2. Create a new job on the kettle platform
      3. Check the delete option
      4. Test whether the data is deleted
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@JNSimba
Copy link
Member Author

JNSimba commented Nov 13, 2024

run buildall

@JNSimba JNSimba changed the title [ecosystem](kettle) add delete mode for kettle [ecosystem](kettle) add delete mode for kettle plugin Nov 13, 2024
CalvinKirs
CalvinKirs previously approved these changes Nov 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@JNSimba
Copy link
Member Author

JNSimba commented Nov 13, 2024

run buildall

@JNSimba JNSimba marked this pull request as draft November 13, 2024 09:45
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@JNSimba JNSimba marked this pull request as ready for review November 14, 2024 02:19
@JNSimba
Copy link
Member Author

JNSimba commented Nov 14, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@JNSimba JNSimba merged commit 6eacbf8 into apache:master Nov 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants