Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) fix BlockFileCache::get_or_set crash #44013

Merged
merged 2 commits into from
Nov 18, 2024
Merged

[fix](cloud) fix BlockFileCache::get_or_set crash #44013

merged 2 commits into from
Nov 18, 2024

Conversation

freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

This is a Plan-B fix, the root cause is under study:

2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
3# 0x00007F8CFE720520 in /lib/x86_64-linux-gnu/libc.so.6
4# std::_Rb_tree_decrement(std::_Rb_tree_node_base*) at ../../../../../libstdc++-v3/src/c++98/tree.cc:123
5# doris::io::BlockFileCache::get_impl[abi:cxx11](doris::io::UInt128Wrapper const&, doris::io::CacheContext const&, doris::io::FileBlock::Range const&, std::lock_guardstd::mutex&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:365
6# doris::io::BlockFileCache::get_or_set(doris::io::UInt128Wrapper const&, unsigned long, unsigned long, doris::io::CacheContext&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:662
7# doris::io::CachedRemoteFileReader::read_at_impl(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/cached_remote_file_reader.cpp:179

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](cloud) fix BlockFileCache::get_or_set crash
1017509 
 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 3# 0x00007F8CFE720520 in /lib/x86_64-linux-gnu/libc.so.6
 4# std::_Rb_tree_decrement(std::_Rb_tree_node_base*) at ../../../../../libstdc++-v3/src/c++98/tree.cc:123
 5# doris::io::BlockFileCache::get_impl[abi:cxx11](doris::io::UInt128Wrapper const&, doris::io::CacheContext const&, doris::io::FileBlock::Range const&, std::lock_guard<std::mutex>&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:365
 6# doris::io::BlockFileCache::get_or_set(doris::io::UInt128Wrapper const&, unsigned long, unsigned long, doris::io::CacheContext&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:662
 7# doris::io::CachedRemoteFileReader::read_at_impl(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/cached_remote_file_reader.cpp:179

Signed-off-by: zhengyu <[email protected]>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.00% (9902/26057)
Line Coverage: 29.17% (82707/283499)
Region Coverage: 28.31% (42489/150096)
Branch Coverage: 24.88% (21544/86584)
Coverage Report: http://coverage.selectdb-in.cc/coverage/101750921c96010d7f9b80b5742d74d0c6ca4d4f_101750921c96010d7f9b80b5742d74d0c6ca4d4f/report/index.html

dataroaring
dataroaring previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@freemandealer
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.98% (9895/26053)
Line Coverage: 29.17% (82715/283520)
Region Coverage: 28.30% (42480/150100)
Branch Coverage: 24.87% (21538/86592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f72edf89d0d5d767dfbacf8836ea23d500e119b2_f72edf89d0d5d767dfbacf8836ea23d500e119b2/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 56bf4b6 into apache:master Nov 18, 2024
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
@freemandealer
[fix](cloud) fix BlockFileCache::get_or_set crash (#44013)
ff44ecf 
This is a Plan-B fix, the root cause is under study:

2# JVM_handle_linux_signal in
/usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
 3# 0x00007F8CFE720520 in /lib/x86_64-linux-gnu/libc.so.6
4# std::_Rb_tree_decrement(std::_Rb_tree_node_base*) at
../../../../../libstdc++-v3/src/c++98/tree.cc:123
5#
doris::io::BlockFileCache::get_impl[abi:cxx11](doris::io::UInt128Wrapper
const&, doris::io::CacheContext const&, doris::io::FileBlock::Range
const&, std::lock_guard<std::mutex>&) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:365
6# doris::io::BlockFileCache::get_or_set(doris::io::UInt128Wrapper
const&, unsigned long, unsigned long, doris::io::CacheContext&) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/block_file_cache.cpp:662
7# doris::io::CachedRemoteFileReader::read_at_impl(unsigned long,
doris::Slice, unsigned long*, doris::io::IOContext const*) at
/home/zcp/repo_center/doris_branch-3.0/doris/be/src/io/cache/cached_remote_file_reader.cpp:179


Signed-off-by: zhengyu <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 20, 2024
@github-actions @freemandealer
branch-3.0: [fix](cloud) fix BlockFileCache::get_or_set crash #44013 (#…
0b98983 
…44146)

Cherry-picked from #44013

Signed-off-by: zhengyu <[email protected]>
Co-authored-by: zhengyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freemandealer @doris-robot @gavinchou @dataroaring