[fix](Nereids) fold const return type does not matched with type coercion #44022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
LiBinfeng-01
force-pushed
the
fix_floor
branch
from
d92176e to
055b113
Compare
|
run buildall |
1 similar comment
|
run buildall |
englefly
approved these changes
Nov 18, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Nov 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…cion (#44022) Related PR: #40744 when executing floor(1) it would castTo decimalV3(3,0) because it need (3,0) to contain it's message. But after fold const, it lost precision(3) because decimalV3 literal class does not have mechanism to save precision Solved: after folding constant, we need to change result type to the type we wanted
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…cion (#44022) Related PR: #40744 when executing floor(1) it would castTo decimalV3(3,0) because it need (3,0) to contain it's message. But after fold const, it lost precision(3) because decimalV3 literal class does not have mechanism to save precision Solved: after folding constant, we need to change result type to the type we wanted
morrySnow
pushed a commit
that referenced
this pull request
Nov 18, 2024
…th type coercion #44022 (#44139) Cherry-picked from #44022 Co-authored-by: LiBinfeng <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Nov 18, 2024
…th type coercion #44022 (#44141) Cherry-picked from #44022 Co-authored-by: LiBinfeng <[email protected]>
morrySnow
added
dev/2.1.8-merged
dev/3.0.3-merged
and removed
dev/2.1.x
dev/3.0.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44021
Related PR: #40744
Problem Summary:
when executing floor(1) it would castTo decimalV3(3,0) because it need (3,0) to contain it's message.
But after fold const, it lost precision(3) because decimalV3 literal class does not have mechanism to save precision
Solved: after folding constant, we need to change result type to the type we wanted
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)