Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](test) Add info about buildKit required with docker-compose #44095

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[chore](test) Add info about buildKit required with docker-compose #44095

merged 3 commits into from
Nov 28, 2024

Conversation

Vallishp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
got error when trying to create docker cluster using private image.
adding more info so that can help others.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed. // no code change. just doc update
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

run buildall

dataroaring
dataroaring approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

deardeng
deardeng approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vallishp
Copy link
Contributor Author

run cloud_p0

@dataroaring dataroaring changed the title [chore] Add info about buildKit required with docker-compose [chore](test) Add info about buildKit required with docker-compose Nov 26, 2024
@Vallishp
Copy link
Contributor Author

run buildall

dataroaring
dataroaring approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 325a67c into apache:master Nov 28, 2024
23 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@Vallishp
[chore](test) Add info about buildKit required with docker-compose (#…
0c308a0 
…44095)


got error when trying to create docker cluster using private image. 
adding more info so that can help others.
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 3, 2024
@github-actions @Vallishp
branch-3.0: [chore](test) Add info about buildKit required with docke…
7e40854 
…r-compose #44095 (#44721)

Cherry-picked from #44095

Co-authored-by: Vallish Pai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@deardeng deardeng deardeng approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vallishp @doris-robot @deardeng @dataroaring