[improve](backup) Add the commit seq at the backup job level. #44049 #44111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
…#44049) Related PR: selectdb/ccr-syncer#237 Problem Summary: When a backup job is created, it will read the database and obtain a set of table refs. If there is a table creation statement running simultaneously and the new table is not included in the table refs, then the job commit seq obtained by the CCR syncer only through the commit seq of the tables included in the snapshot may be greater than that of the new table. Consequently, the table will be lost during the synchronization process. This PR acquires a commit seq within the database read lock as the commit seq of the entire snapshot. In this way, the CCR syncer can continue to synchronize the binlog starting from this value. Thus, the table creation statements running in parallel with the backup job will either be included in the table refs or their binlog can be observed by the snapshot commit sequence.
w41ter
force-pushed
the
pick_44049_to_origin_branch-2.0
branch
from
f457e85 to
0e03cdc
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #44049