Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[Enhancement](jdbc catalog) Support reading some array types of PostgreSQL #44160

merged 2 commits into from
Nov 28, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 22, 2024

run buildall

morningman
morningman reviewed Nov 25, 2024
View reviewed changes
...java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/PostgreSQLJdbcExecutor.java Outdated
} else if (element instanceof byte[]) {
sb.append(pgByteArrayToHexString((byte[]) element));
} else {
String elementStr = element != null ? element.toString().trim() : "null";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use trim()?

fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcPostgreSQLClient.java Outdated
}

String innerType = fieldSchema.getDataTypeName().orElse("unknown").substring(1);
String[] supportedInnerType = new String[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it is static final field

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 26, 2024

run buildall

morningman
morningman approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman closed this Nov 26, 2024
@morningman morningman reopened this Nov 26, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 24f1eef into apache:master Nov 28, 2024
36 of 38 checks passed
@zy-kkk zy-kkk deleted the pg_array branch December 10, 2024 03:02
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@zy-kkk
[Enhancement](jdbc catalog) Support reading some array types of Postg…
eef8779 
…reSQL (#44160)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

```
{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }
```


### Release note

[feat](jdbc catalog) Support reading some array types of PostgreSQL
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Dec 10, 2024
@zy-kkk
[Enhancement](jdbc catalog) Support reading some array types of Postg…
5684985 
…reSQL (apache#44160)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

```
{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }
```


### Release note

[feat](jdbc catalog) Support reading some array types of PostgreSQL
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Dec 10, 2024
@zy-kkk
[Enhancement](jdbc catalog) Support reading some array types of Postg…
ea66ccb 
…reSQL (apache#44160)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

```
{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }
```


### Release note

[feat](jdbc catalog) Support reading some array types of PostgreSQL
morningman pushed a commit that referenced this pull request Dec 20, 2024
@zy-kkk @morningman
[Enhancement](jdbc catalog) Support reading some array types of Postg…
15e3937 
…reSQL (#44160)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR supports reading some PostgreSQL array types, including:

```
{
                "int2", "int4", "int8", "smallserial", "serial",
                "bigserial", "float4", "float8", "timestamp", "timestamptz",
                "date", "bool", "bpchar", "varchar", "text"
        }
```


### Release note

[feat](jdbc catalog) Support reading some array types of PostgreSQL
morningman pushed a commit that referenced this pull request Dec 20, 2024
@github-actions @zy-kkk
branch-3.0: [Enhancement](jdbc catalog) Support reading some array ty…
85e2e99 
…pes of PostgreSQL #44160 (#45219)

Cherry-picked from #44160

Co-authored-by: zy-kkk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x-experimental dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zy-kkk @doris-robot @morningman @CalvinKirs