Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](scan) Release instances of Segment to avoid consuming a large amount of memory in ParallelScannerBuilder #44189

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[opt](scan) Release instances of Segment to avoid consuming a large amount of memory in ParallelScannerBuilder #44189

merged 1 commit into from
Nov 22, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Nov 18, 2024 •
edited
Loading

What problem does this PR solve?

For wide tables, a loaded Segment will consume a large amount of memory, so it is necessary to release instances of Segment as soon as possible.

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented Nov 18, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg mentioned this pull request Nov 18, 2024
Closed
16 tasks
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.01% (9899/26042)
Line Coverage: 29.18% (82730/283548)
Region Coverage: 28.32% (42495/150079)
Branch Coverage: 24.89% (21553/86602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e68f1aa3d0e876921fdb9093876bac686219d801_e68f1aa3d0e876921fdb9093876bac686219d801/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 11276d1 into apache:master Nov 22, 2024
31 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@mrhhsg
[opt](scan) Release instances of Segment to avoid consuming a large a…
634b028 
…mount of memory in ParallelScannerBuilder (#44189)

For wide tables, a loaded Segment will consume a large amount of memory,
so it is necessary to release instances of `Segment` as soon as
possible.
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Merged
eldenmoon pushed a commit that referenced this pull request Nov 22, 2024
@github-actions @mrhhsg
branch-3.0: [opt](scan) Release instances of Segment to avoid consumi…
2122f13 
…ng a large amount of memory in ParallelScannerBuilder #44189 (#44445)

Cherry-picked from #44189

Co-authored-by: Jerry Hu <[email protected]>
@mrhhsg mrhhsg deleted the opt_parallel_scan branch November 26, 2024 06:27
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Nov 26, 2024
@mrhhsg
[opt](scan) Release instances of Segment to avoid consuming a large a…
91cadd8 
…mount of memory in ParallelScannerBuilder (apache#44189)

For wide tables, a loaded Segment will consume a large amount of memory,
so it is necessary to release instances of `Segment` as soon as
possible.
@mrhhsg mrhhsg mentioned this pull request Nov 26, 2024
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Nov 26, 2024
@mrhhsg
[opt](scan) Release instances of Segment to avoid consuming a large a…
9bc5475 
…mount of memory in ParallelScannerBuilder (#44189) (#44608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@jacktengg jacktengg jacktengg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrhhsg @doris-robot @yiguolei @jacktengg @eldenmoon