Test perf #44223
Closed
Test perf #44223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40186 ms |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/exprs/runtime_filter.cpp
Outdated
| @@ -994,20 +994,20 @@ void IRuntimeFilter::insert_batch(const vectorized::ColumnPtr column, size_t sta | |||
| Status IRuntimeFilter::publish(bool publish_local) { | |||
There was a problem hiding this comment.
warning: function 'publish' has cognitive complexity of 82 (threshold 50) [readability-function-cognitive-complexity]
Status IRuntimeFilter::publish(bool publish_local) {
^Additional context
be/src/exprs/runtime_filter.cpp:996: nesting level increased to 1
auto send_to_remote_targets = [&](IRuntimeFilter* filter, uint64_t local_merge_time) {
^be/src/exprs/runtime_filter.cpp:999: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr));
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:999: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr));
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1002: nesting level increased to 1
auto send_to_local_targets = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper, bool global,
^be/src/exprs/runtime_filter.cpp:1014: nesting level increased to 1
auto do_merge = [&]() {
^be/src/exprs/runtime_filter.cpp:1015: +2, including nesting penalty of 1, nesting level increased to 2
if (!_state->global_runtime_filter_mgr()->get_consume_filters(_filter_id).empty()) {
^be/src/exprs/runtime_filter.cpp:1017: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters(
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1017: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters(
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1021: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get()));
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1021: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get()));
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1024: +3, including nesting penalty of 2, nesting level increased to 3
if (local_merge_filters->merge_time == 0) {
^be/src/exprs/runtime_filter.cpp:1025: +4, including nesting penalty of 3, nesting level increased to 4
if (_has_local_target) {
^be/src/exprs/runtime_filter.cpp:1026: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(send_to_local_targets(
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1026: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(send_to_local_targets(
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1029: +1, nesting level increased to 4
} else {
^be/src/exprs/runtime_filter.cpp:1030: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(send_to_remote_targets(
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1030: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(send_to_remote_targets(
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1039: +1, including nesting penalty of 0, nesting level increased to 1
if (_has_local_target) {
^be/src/exprs/runtime_filter.cpp:1042: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(do_merge());
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1042: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(do_merge());
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1043: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(send_to_local_targets(_wrapper, false));
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1043: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(send_to_local_targets(_wrapper, false));
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1044: +1, nesting level increased to 1
} else if (!publish_local) {
^be/src/exprs/runtime_filter.cpp:1045: +2, including nesting penalty of 1, nesting level increased to 2
if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) {
^be/src/exprs/runtime_filter.cpp:1045: +1
if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) {
^be/src/exprs/runtime_filter.cpp:1046: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(send_to_remote_targets(this, 0));
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1046: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(send_to_remote_targets(this, 0));
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1047: +1, nesting level increased to 2
} else {
^be/src/exprs/runtime_filter.cpp:1048: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(do_merge());
^be/src/common/status.h:631: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/exprs/runtime_filter.cpp:1048: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(do_merge());
^be/src/common/status.h:633: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/exprs/runtime_filter.cpp:1050: +1, nesting level increased to 1
} else {
^
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 40628 ms |
TPC-DS: Total hot run time: 193045 ms |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 40558 ms |
TPC-DS: Total hot run time: 188817 ms |
|
run buildall |
TPC-H: Total hot run time: 40700 ms |
TPC-DS: Total hot run time: 195640 ms |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 40256 ms |
TPC-DS: Total hot run time: 190009 ms |
|
run buildall |
TPC-H: Total hot run time: 40265 ms |
TPC-DS: Total hot run time: 190466 ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)