Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement showDeleteCommand in nereids #44296

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[Enhancement] (nereids)implement showDeleteCommand in nereids #44296

merged 2 commits into from
Nov 22, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Nov 19, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42754
[Enhancement] (nereids)implement showDeleteCommand in nereids

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test //updated
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

1 similar comment
@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

starocean999
starocean999 previously approved these changes Nov 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Vallishp
Copy link
Contributor Author

run buildall

3 similar comments
@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit f958509 into apache:master Nov 22, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showDeleteCommand in nereids
4 participants
@Vallishp @doris-robot @starocean999 @LiBinfeng-01