[Bug](function)fix json_object function check null nums error as return bool #44321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
Mryange
approved these changes
Nov 20, 2024
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 40204 ms |
TPC-DS: Total hot run time: 195814 ms |
ClickBench: Total hot run time: 32.82 s |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…rn bool (#44321) ### What problem does this PR solve? Related PR: #https://github.com/apache/doris/pull/34591/files Problem Summary: before the SQL report error, as it error change the simd::count_zero_num function return value static as bool, so it run into the if check of (not_null_num < size). but actual it's maybe return int type. now: ``` mysql [(none)]>select json_object ( CONCAT('k',t.number%30926%3000 + 0),CONCAT('k',t.number%30926%3000 + 0,t.number%1000000) ) from numbers("number" = "2") t order by 1; +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | json_object(concat('k', cast((((number % 30926) % 3000) + 0) as VARCHAR(65533))), concat('k', cast((((number % 30926) % 3000) + 0) as VARCHAR(65533)), cast((number % 1000000) as VARCHAR(65533))), '66') | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | {"k0":"k00"} | | {"k1":"k11"} | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 2 rows in set (0.04 sec) ``` before: ``` mysql [(none)]>select json_object -> ( -> CONCAT('k',t.number%30926%3000 + 0),CONCAT('k',t.number%30926%3000 + 0,t.number%1000000) -> ) -> from numbers("number" = "2") t; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INTERNAL_ERROR]function json_object can not input null value , JSON documents may not contain NULL member names. mysql [(none)]> ```
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…rn bool (#44321) ### What problem does this PR solve? Related PR: #https://github.com/apache/doris/pull/34591/files Problem Summary: before the SQL report error, as it error change the simd::count_zero_num function return value static as bool, so it run into the if check of (not_null_num < size). but actual it's maybe return int type. now: ``` mysql [(none)]>select json_object ( CONCAT('k',t.number%30926%3000 + 0),CONCAT('k',t.number%30926%3000 + 0,t.number%1000000) ) from numbers("number" = "2") t order by 1; +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | json_object(concat('k', cast((((number % 30926) % 3000) + 0) as VARCHAR(65533))), concat('k', cast((((number % 30926) % 3000) + 0) as VARCHAR(65533)), cast((number % 1000000) as VARCHAR(65533))), '66') | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | {"k0":"k00"} | | {"k1":"k11"} | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 2 rows in set (0.04 sec) ``` before: ``` mysql [(none)]>select json_object -> ( -> CONCAT('k',t.number%30926%3000 + 0),CONCAT('k',t.number%30926%3000 + 0,t.number%1000000) -> ) -> from numbers("number" = "2") t; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INTERNAL_ERROR]function json_object can not input null value , JSON documents may not contain NULL member names. mysql [(none)]> ```
yiguolei
pushed a commit
that referenced
this pull request
Nov 22, 2024
…rror as return bool #44321 (#44381) Cherry-picked from #44321 Co-authored-by: zhangstar333 <[email protected]>
dataroaring
pushed a commit
that referenced
this pull request
Nov 26, 2024
…rror as return bool #44321 (#44380) Cherry-picked from #44321 Co-authored-by: zhangstar333 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #https://github.com/apache/doris/pull/34591/files
Problem Summary:
before the SQL report error, as it error change the simd::count_zero_num function return value static as bool,
so it run into the if check of (not_null_num < size).
but actual it's maybe return int type.
now:
before:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)