Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore](runtime-filter) change some rf dcheck to exception #44354

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Chore](runtime-filter) change some rf dcheck to exception #44354

merged 1 commit into from
Nov 21, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

What problem does this PR solve?

change some rf dcheck to exception

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb
zclllyybb approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 3f7af18 into apache:master Nov 21, 2024
28 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@BiteTheDDDDt
[Chore](runtime-filter) change some rf dcheck to exception (#44354)
c14449c 
### What problem does this PR solve?

change some rf dcheck to exception
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
BiteTheDDDDt added a commit that referenced this pull request Nov 27, 2024
@github-actions @BiteTheDDDDt
branch-3.0: [Chore](runtime-filter) change some rf dcheck to exception …
32e8d18 
…#44354 (#44371)

Cherry-picked from #44354

Co-authored-by: Pxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BiteTheDDDDt @zclllyybb @zhangstar333 @dataroaring