Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](cloud) adjust timeout settings for BE brpc connection pool to meta-service #44374

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[improve](cloud) adjust timeout settings for BE brpc connection pool to meta-service #44374

merged 2 commits into from
Nov 25, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Nov 21, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou gavinchou changed the title [improve](selectdb-cloud) adjust the timeout settings for persistent connection [improve](cloud) adjust the timeout settings for persistent connection Nov 21, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou changed the title [improve](cloud) adjust the timeout settings for persistent connection [improve](cloud) adjust the timeout settings for brpc connection pool to meta-service Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou changed the title [improve](cloud) adjust the timeout settings for brpc connection pool to meta-service [improve](cloud) adjust the timeout settings for BE brpc connection pool to meta-service Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou gavinchou changed the title [improve](cloud) adjust the timeout settings for BE brpc connection pool to meta-service [improve](cloud) adjust timeout settings for BE brpc connection pool to meta-service Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.31% (9980/26049)
Line Coverage: 29.44% (83556/283827)
Region Coverage: 28.59% (42993/150360)
Branch Coverage: 25.17% (21838/86746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/98bbe1a33d0c326f441ebd5c6ea9726c8b0d12b8_98bbe1a33d0c326f441ebd5c6ea9726c8b0d12b8/report/index.html

@dataroaring dataroaring merged commit d1bf328 into apache:master Nov 25, 2024
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
@luwei16
[improve](cloud) adjust timeout settings for BE brpc connection pool …
dc47f45 
…to meta-service (#44374)
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 29, 2024
@github-actions @luwei16
branch-3.0: [improve](cloud) adjust timeout settings for BE brpc conn…
8e9eb1c 
…ection pool to meta-service #44374 (#44578)

Cherry-picked from #44374

Co-authored-by: Luwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luwei16 @doris-robot @dataroaring @gavinchou