Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](suites) Fix syncer ingest binlog with multiple replicas #44444

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[fix](suites) Fix syncer ingest binlog with multiple replicas #44444

merged 1 commit into from
Nov 22, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 22, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Nov 22, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

TangSiyang2001
TangSiyang2001 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@w41ter w41ter merged commit 5b20207 into apache:master Nov 22, 2024
33 of 34 checks passed
@w41ter w41ter deleted the fix_ccr_ingest_binlog_with_multi_replica branch November 22, 2024 09:57
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@w41ter
[fix](suites) Fix syncer ingest binlog with multiple replicas (#44444)
152e50f
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 22, 2024
@github-actions @w41ter
branch-3.0: [fix](suites) Fix syncer ingest binlog with multiple repl…
94a6eac 
…icas #44444 (#44486)

Cherry-picked from #44444

Co-authored-by: walter <[email protected]>
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 26, 2024
@w41ter
[fix](suites) Fix syncer ingest binlog with multiple replicas (apache…
a293b21 
…#44444)
@w41ter w41ter mentioned this pull request Nov 26, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@w41ter
[fix](suites) Fix syncer ingest binlog with multiple replicas #44444 (#…
0af123f 
…44587)

cherry pick from #44444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@TangSiyang2001 TangSiyang2001 TangSiyang2001 approved these changes

@bobhan1 bobhan1 bobhan1 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@w41ter @doris-robot @bobhan1 @TangSiyang2001 @dataroaring