Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor](log) Add more information in error message #44452

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[minor](log) Add more information in error message #44452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions be/src/runtime/fragment_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,9 @@ std::string FragmentMgr::dump_pipeline_tasks(TUniqueId& query_id) {
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
return q_ctx->print_all_pipeline_context();
} else {
return fmt::format("Query context (query id = {}) not found. \n", print_id(query_id));
return fmt::format(
"Dump pipeline tasks failed: Query context (query id = {}) not found. \n",
print_id(query_id));
}
}

Expand Down Expand Up @@ -1266,8 +1268,10 @@ Status FragmentMgr::send_filter_size(const PSendFilterSizeRequest* request) {
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
return Status::EndOfFile("Query context (query-id: {}) not found, maybe finished",
queryid.to_string());
return Status::EndOfFile(
"Send filter size failed: Query context (query-id: {}) not found, maybe "
"finished",
queryid.to_string());
}
}

Expand All @@ -1288,8 +1292,9 @@ Status FragmentMgr::sync_filter_size(const PSyncFilterSizeRequest* request) {
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
return Status::InvalidArgument("Query context (query-id: {}) not found",
queryid.to_string());
return Status::InvalidArgument(
"Sync filter size failed: Query context (query-id: {}) not found",
queryid.to_string());
}
}
return query_ctx->runtime_filter_mgr()->sync_filter_size(request);
Expand All @@ -1308,8 +1313,9 @@ Status FragmentMgr::merge_filter(const PMergeFilterRequest* request,
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
return Status::InvalidArgument("Query context (query-id: {}) not found",
queryid.to_string());
return Status::InvalidArgument(
"Merge filter size failed: Query context (query-id: {}) not found",
queryid.to_string());
}
}
SCOPED_ATTACH_TASK(query_ctx.get());
Expand Down
Loading