Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[refine](column) Remove some unnecessary get_int functions." #44466

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 22, 2024

Reverts #44017

In this pr, for some code path that col2's type is not FromType2 we assert it's wrong and throw error. but in fact because of some misuse in our code, many date function didn't specify the FromType2. so the "wrong" path is useful now. Only when we fixed all the calling with wrong FromType2, this pr could be applied.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.31% (9980/26050)
Line Coverage: 29.44% (83553/283821)
Region Coverage: 28.58% (42977/150361)
Branch Coverage: 25.17% (21838/86746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1694f8b9b43820653fbd10ceb79fa5cdfd7ecd1f_1694f8b9b43820653fbd10ceb79fa5cdfd7ecd1f/report/index.html

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 65e99a8 into apache:master Nov 22, 2024
26 of 29 checks passed
@zclllyybb zclllyybb deleted the revert-44017-remove-some-int branch November 22, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants