Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](move-memtable) fix false positives in sinkv2 injection tests #44552

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[test](move-memtable) fix false positives in sinkv2 injection tests #44552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6404967
[test](move-memtable) fix false positives in sinkv2 injection tests
kaijchen Nov 25, 2024
403275a
Merge branch 'master' into fix-sinkv2-injection
kaijchen Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ suite("test_writer_v2_fault_injection", "nonConcurrent") {
file "baseall.txt"
}

def load_with_injection = { injection, error_msg->
def load_with_injection = { injection, error_msg, success=false->
try {
GetDebugPoint().enableDebugPointForAllBEs(injection)
sql "insert into test select * from baseall where k1 <= 3"
assertTrue(success, String.format("expected Exception '%s', actual success", error_msg))
} catch(Exception e) {
logger.info(e.getMessage())
assertTrue(e.getMessage().contains(error_msg),
Expand All @@ -88,7 +89,7 @@ suite("test_writer_v2_fault_injection", "nonConcurrent") {
// VTabletWriterV2 node_info is null
load_with_injection("VTabletWriterV2._open_streams_to_backend.node_info_null", "failed to open streams to any BE")
// VTabletWriterV2 do not get tablet schema on open_streams
load_with_injection("VTabletWriterV2._open_streams_to_backend.no_schema_when_open_streams", "success")
load_with_injection("VTabletWriterV2._open_streams_to_backend.no_schema_when_open_streams", "success", true)
// VTabletWriterV2 tablet_location is null
load_with_injection("VTabletWriterV2._build_tablet_node_mapping.tablet_location_null", "unknown tablet location")
// VTabletWriterV2 location is null
Expand Down
Loading