Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-2.1: [fix](inverted index) Content Check for Tokenize Function Parser #44465 #44555

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44465

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 25, 2024
@doris-robot
Copy link

run buildall

Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.74% (9605/26145)
Line Coverage: 28.15% (79029/280777)
Region Coverage: 26.83% (40615/151394)
Branch Coverage: 23.65% (20664/87378)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5639dc8b57cdadf71ad1838ec15e9c2f9764548_f5639dc8b57cdadf71ad1838ec15e9c2f9764548/report/index.html

)

Problem Summary:
1. Prevent users from mistakenly assuming other tokenizers exist.
@yiguolei yiguolei force-pushed the auto-pick-44465-branch-2.1 branch from f5639dc to 5054865 Compare November 26, 2024 11:32
@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.73% (9607/26154)
Line Coverage: 28.14% (79059/280923)
Region Coverage: 26.83% (40639/151470)
Branch Coverage: 23.64% (20667/87436)
Coverage Report: http://coverage.selectdb-in.cc/coverage/50548656b8070ebdc7a118aecf51aa6701f4bc25_50548656b8070ebdc7a118aecf51aa6701f4bc25/report/index.html

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 66cb95f into branch-2.1 Nov 27, 2024
20 of 24 checks passed
@airborne12 airborne12 deleted the auto-pick-44465-branch-2.1 branch November 27, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants