[fix](backup) Automatic adapt upload/download snapshot batch size #44560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
w41ter
requested review from
dataroaring and
nextdreamblue
and removed request for
dataroaring
w41ter
force-pushed
the
adapt_batch_size
branch
from
4872233 to
a566779
Compare
|
run buildall |
Yukang-Lian
approved these changes
Nov 26, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…4560) The original `backup_upload_task_num_per_be` and `restore_download_task_num_per_be` would not adapt the different num of snapshots, a large `UploadTask` or `DownloadTask` might exceed the threshold of `thrift_max_message_size` and failed forever. This PR changes these options to adapt the number of snapshots automatically.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…4560) The original `backup_upload_task_num_per_be` and `restore_download_task_num_per_be` would not adapt the different num of snapshots, a large `UploadTask` or `DownloadTask` might exceed the threshold of `thrift_max_message_size` and failed forever. This PR changes these options to adapt the number of snapshots automatically.
dataroaring
pushed a commit
that referenced
this pull request
Nov 27, 2024
…tch size #44560 (#44639) Cherry-picked from #44560 Co-authored-by: walter <[email protected]>
yiguolei
pushed a commit
that referenced
this pull request
Nov 27, 2024
…4560) The original `backup_upload_task_num_per_be` and `restore_download_task_num_per_be` would not adapt the different num of snapshots, a large `UploadTask` or `DownloadTask` might exceed the threshold of `thrift_max_message_size` and failed forever. This PR changes these options to adapt the number of snapshots automatically.
dataroaring
pushed a commit
that referenced
this pull request
Nov 28, 2024
…tch size #44560 (#44641) Cherry-picked from #44560 Co-authored-by: walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The original
backup_upload_task_num_per_beandrestore_download_task_num_per_bewould not adapt the different num of snapshots, a largeUploadTaskorDownloadTaskmight exceed the threshold ofthrift_max_message_sizeand failed forever.This PR changes these options to adapt the number of snapshots automatically.
Release note
None
Check List (For Author)
Test
Behavior changed:
Now each the number of snapshots assigned to a download/upload task is limited, and no num limitations of download/upload tasks are applied.
Does this need documentation?
Add restore_download_snapshot_batch_size/backup_upload_snapshot_batch_size config doris-website#1409
Check List (For Reviewer who merge this PR)