Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](insert) Fix ENABLE_AUTO_CREATE_WHEN_OVERWRITE forward to Master #44570

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 25, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

When insert overwrite auto detect statement execute by follower, it's will not set ENABLE_AUTO_CREATE_WHEN_OVERWRITE correctly because the insert stmt will forward to master to execute by the variable will not forward. not fixed it.

Release note

(no release note for 2.1 needed because the base function has not been released now)
for 3.0: Fix insert overwrite auto detect failed executing by follower.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
      • we will specially design stress case for it
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 680c572 into apache:master Nov 26, 2024
34 of 36 checks passed
@zclllyybb zclllyybb deleted the forward branch November 26, 2024 03:17
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
…#44570)


Problem Summary:

When insert overwrite auto detect statement execute by follower, it's
will not set ENABLE_AUTO_CREATE_WHEN_OVERWRITE correctly because the
insert stmt will forward to master to execute by the variable will not
forward. not fixed it.

### Release note

(no release note for 2.1 needed because the base function has not been
released now)
for 3.0: Fix insert overwrite auto detect failed executing by follower.
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 26, 2024
…apache#44570)

Problem Summary:

When insert overwrite auto detect statement execute by follower, it's
will not set ENABLE_AUTO_CREATE_WHEN_OVERWRITE correctly because the
insert stmt will forward to master to execute by the variable will not
forward. not fixed it.

(no release note for 2.1 needed because the base function has not been
released now)
for 3.0: Fix insert overwrite auto detect failed executing by follower.
BiteTheDDDDt pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants