[fix](mtmv) Fix filter position different but same causing rewritten by materialized view fail #44575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39717 ms |
TPC-DS: Total hot run time: 196918 ms |
ClickBench: Total hot run time: 33.7 s |
|
run buildall |
TPC-H: Total hot run time: 39481 ms |
TPC-DS: Total hot run time: 196127 ms |
ClickBench: Total hot run time: 33 s |
seawinde
force-pushed
the
fix_same_filter_but_position_diff_rewrite_fail
branch
from
4973cdf to
4069368
Compare
…by materialized view fail
seawinde
force-pushed
the
fix_same_filter_but_position_diff_rewrite_fail
branch
from
4069368 to
281401c
Compare
|
run buildall |
TPC-H: Total hot run time: 40149 ms |
TPC-DS: Total hot run time: 197687 ms |
ClickBench: Total hot run time: 33.25 s |
morrySnow
approved these changes
Dec 2, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Dec 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…by materialized view fail (#44575) Such as mv def is as following and query is the same this is the same filter `l_orderkey is null or l_orderkey <> 1` but they are in the different position. this would cause rewrite fail, this pr fix this. ```sql select o_custkey, o_orderdate, o_shippriority, o_comment, o_orderkey, orders.public_col as col1, l_orderkey, l_partkey, l_suppkey, lineitem.public_col as col2, ps_partkey, ps_suppkey, partsupp.public_col as col3, partsupp.public_col * 2 as col4, o_orderkey + l_orderkey + ps_partkey * 2, sum( o_orderkey + l_orderkey + ps_partkey * 2 ), count() as count_all from ( select o_custkey, o_orderdate, o_shippriority, o_comment, o_orderkey, orders.public_col as public_col from orders ) orders left join ( select l_orderkey, l_partkey, l_suppkey, lineitem.public_col as public_col from lineitem where l_orderkey is null or l_orderkey <> 1 ) lineitem on l_orderkey = o_orderkey inner join ( select ps_partkey, ps_suppkey, partsupp.public_col as public_col from partsupp ) partsupp on ps_partkey = o_orderkey and ps_suppkey = o_custkey where l_orderkey is null or l_orderkey <> 1 group by 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14; ``` Related PR: #34753 Fix filter position different but same causing rewritten by materialized view fail
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…by materialized view fail (#44575) Such as mv def is as following and query is the same this is the same filter `l_orderkey is null or l_orderkey <> 1` but they are in the different position. this would cause rewrite fail, this pr fix this. ```sql select o_custkey, o_orderdate, o_shippriority, o_comment, o_orderkey, orders.public_col as col1, l_orderkey, l_partkey, l_suppkey, lineitem.public_col as col2, ps_partkey, ps_suppkey, partsupp.public_col as col3, partsupp.public_col * 2 as col4, o_orderkey + l_orderkey + ps_partkey * 2, sum( o_orderkey + l_orderkey + ps_partkey * 2 ), count() as count_all from ( select o_custkey, o_orderdate, o_shippriority, o_comment, o_orderkey, orders.public_col as public_col from orders ) orders left join ( select l_orderkey, l_partkey, l_suppkey, lineitem.public_col as public_col from lineitem where l_orderkey is null or l_orderkey <> 1 ) lineitem on l_orderkey = o_orderkey inner join ( select ps_partkey, ps_suppkey, partsupp.public_col as public_col from partsupp ) partsupp on ps_partkey = o_orderkey and ps_suppkey = o_custkey where l_orderkey is null or l_orderkey <> 1 group by 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14; ``` Related PR: #34753 Fix filter position different but same causing rewritten by materialized view fail
yiguolei
pushed a commit
that referenced
this pull request
Dec 4, 2024
…g rewritten by materialized view fail #44575 (#44900) Cherry-picked from #44575 Co-authored-by: seawinde <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Dec 6, 2024
…g rewritten by materialized view fail #44575 (#44899) Cherry-picked from #44575 Co-authored-by: seawinde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Such as mv def is as following and query is the same
this is the same filter
l_orderkey is null or l_orderkey <> 1but they are in the different position. this would cause rewrite fail, this pr fix this.Issue Number: close #xxx
Related PR: #34753
Problem Summary:
Release note
Fix filter position different but same causing rewritten by materialized view fail
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)