Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](ip-search)fix ip search with inverted index #44580

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[fix](ip-search)fix ip search with inverted index #44580

merged 2 commits into from
Nov 28, 2024
+12 −6

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Nov 26, 2024 •
edited
Loading

What problem does this PR solve?

this pr is to solve is_ip_address_in_range with invalid param
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

run buildall

airborne12
airborne12 previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be some UT tests needed.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.34% (9980/26032)
Line Coverage: 29.43% (83509/283768)
Region Coverage: 28.61% (42997/150296)
Branch Coverage: 25.18% (21836/86720)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fec0c033ed7f779735beb4b58fdcd74161098de9_fec0c033ed7f779735beb4b58fdcd74161098de9/report/index.html

zzzxl1993
zzzxl1993 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.36% (9978/26013)
Line Coverage: 29.45% (83505/283505)
Region Coverage: 28.60% (42985/150286)
Branch Coverage: 25.21% (21838/86622)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7171dcdc68ec615386a13004542b09490dbc8da3_7171dcdc68ec615386a13004542b09490dbc8da3/report/index.html

zzzxl1993
zzzxl1993 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amorynan amorynan requested a review from airborne12 November 28, 2024 01:33
eldenmoon
eldenmoon approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@eldenmoon eldenmoon merged commit 016d389 into apache:master Nov 28, 2024
24 of 26 checks passed
amorynan added a commit to amorynan/doris that referenced this pull request Nov 28, 2024
@amorynan
[fix](ip-search)fix ip search with inverted index (apache#44580)
5899fbc 
this pr is to solve is_ip_address_in_range with invalid param
amorynan added a commit to amorynan/doris that referenced this pull request Nov 28, 2024
@amorynan
[fix](ip-search)fix ip search with inverted index (apache#44580)
a4b6417 
this pr is to solve is_ip_address_in_range with invalid param
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
@amorynan
[fix](ip-search)fix ip search with inverted index (#44580)
6436905 
this pr is to solve is_ip_address_in_range with invalid param
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
airborne12 pushed a commit that referenced this pull request Nov 29, 2024
@amorynan
[fix](ip-search)fix ip search with inverted index (#44580) (#44712)
ad29b07 
this pr is to solve is_ip_address_in_range with invalid param
pick from #44712
airborne12 pushed a commit that referenced this pull request Nov 29, 2024
@github-actions @amorynan
branch-3.0: [fix](ip-search)fix ip search with inverted index #44580 (#…
ec5ffad 
…44762)

Cherry-picked from #44580

Co-authored-by: amory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

@airborne12 airborne12 Awaiting requested review from airborne12

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amorynan @doris-robot @airborne12 @zzzxl1993 @eldenmoon @wm1581066