Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](Nereids) let lead and lag type coersion behavior same with MySQL #44590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

For input and default are numeric types, use below priority

  • DecimalV3
  • DecimalV2
  • Double
  • Float
  • LargeInt
  • BigInt
  • Int
  • SmallInt
  • TinyInt

For input and default are Date or DateTime types, user below priority

  • DateTimeV2
  • DateTime
  • DateV2
  • Date

other wise, use String

Release note

Change the signature matching behavior of Lead and Lag to make it more intuitive.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow marked this pull request as ready for review November 27, 2024 10:21
For input and default are numeric types, use below priority
- DecimalV3
- DecimalV2
- Double
- Float
- LargeInt
- BigInt
- Int
- SmallInt
- TinyInt

For input and default are Date or DateTime types, user below priority
- DateTimeV2
- DateTime
- DateV2
- Date

other wise, use String
@morrySnow morrySnow force-pushed the fix_lag_and_lead_type branch from 68c34c4 to 953e5e9 Compare December 10, 2024 11:05
@morrySnow
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants