Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids) limit should not push into PartitionTopN when window's following frame is not current row #44604

Closed
wants to merge 1 commit into from

Conversation

924060929
Copy link
Contributor

@924060929 924060929 commented Nov 26, 2024

What problem does this PR solve?

limit should not push into PartitionTopN when window's following frame is not current row

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929 924060929 changed the title [fix](nereids) limit should not push into PartitionTopN when window has following frame [fix](nereids) limit should not push into PartitionTopN when window's following frame is not current row Nov 26, 2024
FrameBoundary rightBoundary = frame.getRightBoundary();
if (rightBoundary.getFrameBoundType() == FrameBoundType.UNBOUNDED_FOLLOWING) {
return null;
} else if (frameUnits == FrameUnitsType.ROWS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about range frame?

Copy link
Contributor Author

@924060929 924060929 Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range frame only support RANGE UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING , RANGE CURRENT ROW AND UNBOUNDED FOLLOWING and RANGE UNBOUNDED PRECEDING AND CURRENT ROW, we should skip in the first two cases

@morrySnow morrySnow added usercase Important user case type label p0_w labels Nov 26, 2024
@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 closed this Nov 26, 2024
@yiguolei yiguolei removed the dev/2.1.x label Dec 2, 2024
@morrySnow morrySnow removed usercase Important user case type label p0_w dev/3.0.x labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants