Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compaction)Fix cluster key column duplicated in value columns group #44610

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[fix](compaction)Fix cluster key column duplicated in value columns group #44610

merged 3 commits into from
Nov 28, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Nov 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44609

Related pr: #40372

Problem Summary:

key_columns will be used after move.
This will cause skip in construction of value_columns useless.
cluster key column will be duplicated added in value column group.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qidaye
[fix](compaction)Fix cluster key column duplicated in value columns g…
a803bdc 
…roup

`key_columns` will be used after move.
This will cause skip in construction of `value_columns` useless.
@qidaye qidaye force-pushed the fix_compaction_duplicated_column branch from 33cc312 to a803bdc Compare November 26, 2024 06:47
@qidaye
Copy link
Contributor Author

qidaye commented Nov 26, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.37% (9980/26007)
Line Coverage: 29.46% (83508/283477)
Region Coverage: 28.61% (42997/150280)
Branch Coverage: 25.21% (21834/86624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a803bdc997e23ead1cd6e7e5d4e12de42c63ba13_a803bdc997e23ead1cd6e7e5d4e12de42c63ba13/report/index.html

@qidaye
Copy link
Contributor Author

qidaye commented Nov 26, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.36% (9978/26013)
Line Coverage: 29.46% (83522/283501)
Region Coverage: 28.60% (42988/150284)
Branch Coverage: 25.20% (21830/86622)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8644ebbdc545c2367ee1e7a818d67f363282aec2_8644ebbdc545c2367ee1e7a818d67f363282aec2/report/index.html

airborne12
airborne12 previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye
Copy link
Contributor Author

qidaye commented Nov 27, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.34% (9974/26016)
Line Coverage: 29.44% (83498/283604)
Region Coverage: 28.59% (42978/150335)
Branch Coverage: 25.18% (21823/86658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bdac6373940b03af0dbca59f0a5b6533b665085d_bdac6373940b03af0dbca59f0a5b6533b665085d/report/index.html

airborne12
airborne12 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye qidaye merged commit 0f90d46 into apache:master Nov 28, 2024
22 of 24 checks passed
@qidaye qidaye deleted the fix_compaction_duplicated_column branch November 28, 2024 02:32
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@qidaye
[fix](compaction)Fix cluster key column duplicated in value columns g…
29859c3 
…roup (#44610)

Issue Number: close #44609

Related pr: #40372

Problem Summary:

`key_columns` will be used after move.
This will cause skip in construction of `value_columns` useless.
cluster key  column will be duplicated added in value column group.
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
qidaye added a commit that referenced this pull request Nov 28, 2024
@github-actions @qidaye
branch-3.0: [fix](compaction)Fix cluster key column duplicated in val…
755d35c 
…ue columns group #44610 (#44709)

Cherry-picked from #44610

---------

Co-authored-by: qiye <[email protected]>
@qidaye qidaye removed the dev/3.0.x label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymeiyi mymeiyi mymeiyi approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] compaction failed
4 participants
@qidaye @doris-robot @airborne12 @mymeiyi