Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor](vec) Remove the unless api in IColumn #44619

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

HappenLee
Copy link
Contributor

What problem does this PR solve?

Remove the unless api in IColumn

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39880 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 49701f1c1a19b23819f9ce916c9df3b82d75d832, data reload: false

------ Round 1 ----------------------------------
q1	17595	7581	7290	7290
q2	2060	173	162	162
q3	10678	1087	1158	1087
q4	10472	789	723	723
q5	7566	2734	2711	2711
q6	240	153	150	150
q7	1003	642	608	608
q8	9251	1845	1891	1845
q9	6556	6418	6423	6418
q10	7019	2314	2321	2314
q11	464	274	268	268
q12	433	228	233	228
q13	17768	3055	3022	3022
q14	253	212	224	212
q15	582	553	524	524
q16	631	583	598	583
q17	973	581	558	558
q18	7434	6782	6677	6677
q19	1333	989	1054	989
q20	468	185	183	183
q21	4034	3156	3011	3011
q22	385	332	317	317
Total cold run time: 107198 ms
Total hot run time: 39880 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7226	7226	7234	7226
q2	326	236	237	236
q3	2932	2814	2973	2814
q4	2074	1844	1812	1812
q5	5724	5707	5672	5672
q6	229	142	147	142
q7	2296	1840	1852	1840
q8	3430	3583	3546	3546
q9	8820	8995	8992	8992
q10	3632	3566	3592	3566
q11	613	511	524	511
q12	874	600	625	600
q13	11492	3295	3263	3263
q14	331	285	267	267
q15	574	516	524	516
q16	684	658	643	643
q17	1858	1649	1628	1628
q18	8435	7915	7735	7735
q19	1715	1620	1587	1587
q20	2152	1887	1901	1887
q21	5594	5536	5449	5449
q22	645	571	550	550
Total cold run time: 71656 ms
Total hot run time: 60482 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197014 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 49701f1c1a19b23819f9ce916c9df3b82d75d832, data reload: false

query1	1260	932	965	932
query2	6248	2198	2064	2064
query3	10916	4166	4131	4131
query4	67930	30051	23596	23596
query5	5013	481	473	473
query6	424	189	182	182
query7	5639	309	291	291
query8	317	237	229	229
query9	9270	2634	2618	2618
query10	451	249	241	241
query11	17449	15297	15889	15297
query12	160	97	103	97
query13	1621	419	436	419
query14	11160	7009	7331	7009
query15	223	181	202	181
query16	7724	497	514	497
query17	1073	588	591	588
query18	1833	319	310	310
query19	205	164	158	158
query20	116	112	115	112
query21	219	108	107	107
query22	4694	4510	4652	4510
query23	34952	34354	34516	34354
query24	5466	2555	2622	2555
query25	502	402	398	398
query26	674	153	150	150
query27	1953	292	297	292
query28	4221	2450	2470	2450
query29	721	421	410	410
query30	217	160	148	148
query31	1011	802	841	802
query32	68	54	58	54
query33	398	281	287	281
query34	948	528	523	523
query35	860	741	760	741
query36	1089	968	987	968
query37	126	80	73	73
query38	4470	4514	4433	4433
query39	1545	1451	1456	1451
query40	202	101	105	101
query41	44	46	49	46
query42	126	100	98	98
query43	554	514	520	514
query44	1245	850	858	850
query45	187	168	168	168
query46	1178	725	732	725
query47	2021	1895	1928	1895
query48	420	338	326	326
query49	741	393	409	393
query50	827	432	393	393
query51	7254	7025	7051	7025
query52	99	89	90	89
query53	257	182	179	179
query54	533	405	397	397
query55	75	75	80	75
query56	261	247	239	239
query57	1290	1158	1144	1144
query58	214	221	216	216
query59	3327	3081	3134	3081
query60	280	255	263	255
query61	110	154	107	107
query62	788	687	667	667
query63	222	193	189	189
query64	1374	669	626	626
query65	3323	3203	3267	3203
query66	713	302	312	302
query67	16062	15779	15516	15516
query68	3963	597	560	560
query69	418	257	255	255
query70	1134	1179	1148	1148
query71	356	250	252	250
query72	6490	4051	4072	4051
query73	770	371	366	366
query74	10311	9053	9027	9027
query75	3381	2672	2696	2672
query76	1798	1132	1197	1132
query77	527	284	299	284
query78	10530	9421	9311	9311
query79	1433	602	599	599
query80	1052	437	429	429
query81	532	247	230	230
query82	249	117	129	117
query83	205	183	151	151
query84	273	72	69	69
query85	1005	297	303	297
query86	376	264	311	264
query87	4852	4574	4498	4498
query88	3652	2325	2204	2204
query89	425	287	299	287
query90	2010	197	186	186
query91	141	105	105	105
query92	70	52	51	51
query93	2283	552	560	552
query94	885	307	300	300
query95	354	263	254	254
query96	630	347	270	270
query97	2945	2650	2692	2650
query98	232	195	200	195
query99	1615	1311	1306	1306
Total cold run time: 321790 ms
Total hot run time: 197014 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 49701f1c1a19b23819f9ce916c9df3b82d75d832, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.08
query4	1.60	0.10	0.10
query5	0.44	0.42	0.40
query6	1.14	0.66	0.67
query7	0.01	0.02	0.01
query8	0.03	0.04	0.02
query9	0.56	0.53	0.50
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.62	0.61	0.60
query14	2.78	2.81	2.85
query15	0.90	0.82	0.82
query16	0.39	0.37	0.39
query17	1.07	1.03	1.02
query18	0.23	0.21	0.22
query19	1.98	1.91	2.04
query20	0.01	0.01	0.01
query21	15.37	0.59	0.59
query22	2.85	2.60	1.74
query23	16.88	0.91	0.82
query24	3.29	0.57	1.06
query25	0.21	0.23	0.11
query26	0.41	0.13	0.13
query27	0.05	0.05	0.03
query28	10.76	1.09	1.07
query29	12.64	3.25	3.24
query30	0.25	0.06	0.06
query31	2.88	0.39	0.38
query32	3.26	0.47	0.47
query33	3.00	3.03	3.04
query34	16.96	4.51	4.51
query35	4.60	4.49	4.54
query36	0.67	0.51	0.49
query37	0.09	0.06	0.07
query38	0.05	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 107.5 s
Total hot run time: 32.37 s

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40252 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ceaba630a109681cf7fd760e36f2d6b959f9b387, data reload: false

------ Round 1 ----------------------------------
q1	17917	7596	7284	7284
q2	2053	172	165	165
q3	10682	1128	1212	1128
q4	10503	711	716	711
q5	7587	2785	2754	2754
q6	241	145	146	145
q7	960	655	600	600
q8	9252	1898	1914	1898
q9	6682	6568	6543	6543
q10	7006	2283	2356	2283
q11	460	261	256	256
q12	426	224	227	224
q13	17767	3031	3001	3001
q14	234	206	215	206
q15	572	533	510	510
q16	628	605	585	585
q17	970	534	567	534
q18	7549	6751	6815	6751
q19	1342	973	1053	973
q20	487	178	178	178
q21	4122	3239	3218	3218
q22	377	305	312	305
Total cold run time: 107817 ms
Total hot run time: 40252 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7258	7249	7213	7213
q2	340	224	228	224
q3	2920	2921	2925	2921
q4	2087	1867	1894	1867
q5	5649	5739	5682	5682
q6	224	143	140	140
q7	2262	1793	1778	1778
q8	3417	3582	3528	3528
q9	8948	9098	9141	9098
q10	3595	3559	3559	3559
q11	600	524	499	499
q12	840	599	632	599
q13	8862	3208	3243	3208
q14	308	272	269	269
q15	569	517	510	510
q16	687	662	655	655
q17	1850	1623	1624	1623
q18	8615	7841	7540	7540
q19	1748	1638	1589	1589
q20	2102	1878	1874	1874
q21	5594	5497	5505	5497
q22	649	562	594	562
Total cold run time: 69124 ms
Total hot run time: 60435 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.37% (9980/26011)
Line Coverage: 29.45% (83571/283759)
Region Coverage: 28.60% (43021/150428)
Branch Coverage: 25.21% (21852/86686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ceaba630a109681cf7fd760e36f2d6b959f9b387_ceaba630a109681cf7fd760e36f2d6b959f9b387/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 197092 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ceaba630a109681cf7fd760e36f2d6b959f9b387, data reload: false

query1	1268	940	932	932
query2	6263	2006	1968	1968
query3	11026	4549	4634	4549
query4	67881	29411	23608	23608
query5	5060	482	446	446
query6	405	185	182	182
query7	5687	318	297	297
query8	326	235	238	235
query9	9258	2638	2657	2638
query10	485	255	267	255
query11	17511	15473	15748	15473
query12	151	100	106	100
query13	1541	414	420	414
query14	10729	7212	7578	7212
query15	223	185	197	185
query16	7769	479	477	477
query17	1068	571	583	571
query18	1837	307	308	307
query19	216	157	165	157
query20	118	127	115	115
query21	216	106	106	106
query22	4782	4577	4388	4388
query23	35681	34463	34485	34463
query24	5713	2501	2532	2501
query25	477	382	384	382
query26	641	152	145	145
query27	1835	285	288	285
query28	4347	2445	2432	2432
query29	665	420	410	410
query30	208	151	146	146
query31	1021	831	833	831
query32	64	56	56	56
query33	507	299	296	296
query34	950	520	531	520
query35	885	783	742	742
query36	1099	963	964	963
query37	118	68	75	68
query38	4450	4489	4370	4370
query39	1532	1470	1487	1470
query40	203	103	102	102
query41	45	40	44	40
query42	110	99	104	99
query43	529	478	479	478
query44	1182	833	835	833
query45	190	161	165	161
query46	1161	701	718	701
query47	2070	1921	1938	1921
query48	424	328	318	318
query49	720	398	386	386
query50	834	406	393	393
query51	7400	7061	7139	7061
query52	93	90	86	86
query53	258	181	174	174
query54	520	404	401	401
query55	85	77	79	77
query56	248	227	230	227
query57	1262	1148	1157	1148
query58	210	214	213	213
query59	3065	2970	2862	2862
query60	267	240	239	239
query61	102	114	114	114
query62	771	688	676	676
query63	211	184	198	184
query64	1354	677	685	677
query65	3278	3201	3195	3195
query66	707	301	301	301
query67	16029	15568	15575	15568
query68	4266	556	549	549
query69	412	247	253	247
query70	1196	1029	1144	1029
query71	353	245	243	243
query72	6214	4114	4089	4089
query73	771	356	365	356
query74	10360	8993	8919	8919
query75	3405	2686	2643	2643
query76	1950	1072	1089	1072
query77	525	273	288	273
query78	10455	9414	9348	9348
query79	2134	585	587	585
query80	1047	424	438	424
query81	504	241	237	237
query82	264	116	168	116
query83	179	145	139	139
query84	286	70	68	68
query85	1127	299	297	297
query86	464	300	297	297
query87	4735	4531	4476	4476
query88	4421	2201	2187	2187
query89	418	299	291	291
query90	2093	188	188	188
query91	137	109	104	104
query92	62	54	51	51
query93	2514	556	543	543
query94	867	294	291	291
query95	350	252	260	252
query96	623	277	280	277
query97	2863	2674	2674	2674
query98	234	189	195	189
query99	1629	1345	1308	1308
Total cold run time: 324199 ms
Total hot run time: 197092 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ceaba630a109681cf7fd760e36f2d6b959f9b387, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.04
query3	0.23	0.07	0.06
query4	1.64	0.10	0.10
query5	0.43	0.41	0.41
query6	1.14	0.66	0.65
query7	0.01	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.53
query10	0.53	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.60	0.60
query14	2.82	2.75	2.75
query15	0.90	0.83	0.83
query16	0.38	0.39	0.38
query17	1.05	1.04	1.06
query18	0.22	0.21	0.21
query19	1.98	1.83	2.01
query20	0.01	0.01	0.01
query21	15.37	0.58	0.58
query22	2.55	2.75	1.77
query23	16.77	1.06	0.89
query24	2.90	0.47	1.34
query25	0.13	0.08	0.06
query26	0.65	0.14	0.15
query27	0.05	0.05	0.04
query28	10.81	1.10	1.07
query29	12.57	3.23	3.18
query30	0.25	0.06	0.05
query31	2.86	0.38	0.39
query32	3.27	0.48	0.47
query33	2.95	3.11	2.99
query34	16.80	4.50	4.53
query35	4.53	4.54	4.54
query36	0.67	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 106.54 s
Total hot run time: 32.14 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 46575e5 into apache:master Nov 29, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants