Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](auth)Fix the need for low-level table permissions when querying views in certain situations #44621

Merged
merged 5 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ public class StatementContext implements Closeable {

private Backend groupCommitMergeBackend;

private boolean viewPrivChecked;

public StatementContext() {
this(ConnectContext.get(), null, 0);
}
Expand Down Expand Up @@ -580,4 +582,12 @@ public void setGroupCommitMergeBackend(
Backend groupCommitMergeBackend) {
this.groupCommitMergeBackend = groupCommitMergeBackend;
}

public boolean isViewPrivChecked() {
return viewPrivChecked;
}

public void setViewPrivChecked(boolean viewPrivChecked) {
this.viewPrivChecked = viewPrivChecked;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,13 @@ public class CheckPrivileges extends ColumnPruning {

@Override
public Plan rewriteRoot(Plan plan, JobContext jobContext) {
// Only enter once, if repeated, the permissions of the table in the view will be checked
if (jobContext.getCascadesContext().getStatementContext().isViewPrivChecked()) {
return plan;
}
this.jobContext = jobContext;
super.rewriteRoot(plan, jobContext);

jobContext.getCascadesContext().getStatementContext().setViewPrivChecked(true);
// don't rewrite plan
return plan;
}
Expand Down
89 changes: 89 additions & 0 deletions regression-test/suites/auth_p0/test_select_view_auth.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_select_view_auth","p0,auth") {
String suiteName = "test_select_view_auth"
String user = "${suiteName}_user"
String pwd = 'C123_567p'
String dbName = "${suiteName}_db"
String tableName1 = "${suiteName}_table1"
String tableName2 = "${suiteName}_table2"
String viewName = "${suiteName}_view"

try_sql("drop user ${user}")
try_sql """drop table if exists ${dbName}.${tableName1}"""
try_sql """drop table if exists ${dbName}.${tableName2}"""
try_sql """drop view if exists ${dbName}.${viewName}"""
sql """drop database if exists ${dbName}"""

sql """create user '${user}' IDENTIFIED by '${pwd}'"""

//cloud-mode
if (isCloudMode()) {
def clusters = sql " SHOW CLUSTERS; "
assertTrue(!clusters.isEmpty())
def validCluster = clusters[0][0]
sql """GRANT USAGE_PRIV ON CLUSTER ${validCluster} TO ${user}""";
}
sql """create database ${dbName}"""
sql("""use ${dbName}""")
sql """
CREATE TABLE IF NOT EXISTS ${dbName}.`${tableName1}` (
id BIGINT,
username VARCHAR(20)
)
DISTRIBUTED BY HASH(id) BUCKETS 2
PROPERTIES (
"replication_num" = "1"
);
"""

sql """
CREATE TABLE IF NOT EXISTS ${dbName}.`${tableName2}` (
id BIGINT,
username VARCHAR(20)
)
DISTRIBUTED BY HASH(id) BUCKETS 2
PROPERTIES (
"replication_num" = "1"
);
"""

sql """create view ${dbName}.${viewName} as select * from ${dbName}.${tableName1} union select * from ${dbName}.${tableName2};"""

sql """grant select_priv on regression_test to ${user}"""

// table column
connect(user=user, password="${pwd}", url=context.config.jdbcUrl) {
try {
sql "select * from ${dbName}.${viewName}"
} catch (Exception e) {
log.info(e.getMessage())
assertTrue(e.getMessage().contains("denied"))
}
}
sql """grant select_priv on ${dbName}.${viewName} to ${user}"""
connect(user=user, password="${pwd}", url=context.config.jdbcUrl) {
sql "select * from ${dbName}.${viewName}"
}

try_sql("drop user ${user}")
try_sql """drop table if exists ${dbName}.${tableName1}"""
try_sql """drop table if exists ${dbName}.${tableName2}"""
try_sql """drop view if exists ${dbName}.${viewName}"""
sql """drop database if exists ${dbName}"""
}