Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement](shuffle) Use a knob to decide whether a serial exchange… #44676

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[Improvement](shuffle) Use a knob to decide whether a serial exchange… #44676

merged 1 commit into from
Nov 28, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 27, 2024 •
edited
Loading

… should be used

What problem does this PR solve?

This improvement was completed in #43199 and reverted by #44075 due to performance fallback. After fixing it, this improvement is re-submited.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

1 similar comment
@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.32% (9973/26025)
Line Coverage: 29.42% (83485/283764)
Region Coverage: 28.57% (42974/150434)
Branch Coverage: 25.18% (21824/86672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/beee849cc8e4e2485da2ca86c118b081f4e3e46a_beee849cc8e4e2485da2ca86c118b081f4e3e46a/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit d77bfa0 into apache:master Nov 28, 2024
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@Gabriel39
[Improvement](shuffle) Use a knob to decide whether a serial exchange… (
330e2b5 
#44676)

… should be used

This improvement was completed in #43199 and reverted by #44075 due to performance fallback. After fixing it, this improvement is re-submited.

A new knob to control a exchange node should be serial or not.
For example, a partitioned hash join should be executed like below:
```
┌────────────────────────────┐                  ┌────────────────────────────┐
│                            │                  │                            │
│Exchange(HASH PARTITIONED N)│                  │Exchange(HASH PARTITIONED N)│
│                            │                  │                            │
└────────────────────────────┴─────────┬────────┴────────────────────────────┘
                                       │                                      
                                       │                                      
                                       │                                      
                                       │                                      
                                       │                                      
                                       │                                      
                                ┌──────▼──────┐                               
                                │             │                               
                                │ HASH  JOIN  │                               
                                │             │                               
                                └─────────────┘                               
```          

After turning on this knob, the real plan should be:
```
  ┌──────────────────────────────┐                        ┌──────────────────────────────┐    
  │                              │                        │                              │    
  │ Exchange (HASH PARTITIONED 1)│                        │ Exchange (HASH PARTITIONED 1)│    
  │                              │                        │                              │    
  └────────────┬─────────────────┘                        └────────────┬─────────────────┘    
               │                                                       │                      
               │                                                       │                      
               │                                                       │                      
               │                                                       │                      
               │                                                       │                      
┌──────────────▼─────────────────────┐                  ┌──────────────▼─────────────────────┐
│                                    │                  │                                    │
│ Local  Exchange(HASH PARTITIONED N)│                  │ Local  Exchange(HASH PARTITIONED N)│
│              1 -> N                │                  │              1 -> N                │
└────────────────────────────────────┴─────────┬────────┴────────────────────────────────────┴
                                               │                                              
                                               │                                              
                                               │                                              
                                               │                                              
                                               │                                              
                                               │                                              
                                        ┌──────▼──────┐                                       
                                        │             │                                       
                                        │ HASH  JOIN  │                                       
                                        │             │                                       
                                        └─────────────┘                                       
```

For large cluster, X (mappers) * Y (reducers) rpc channels can be reduced to X (mappers) * Z (BEs).
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
Gabriel39 added a commit that referenced this pull request Dec 2, 2024
@github-actions @Gabriel39
branch-3.0: [Improvement](shuffle) Use a knob to decide whether a ser…
cb5a0b7 
…ial exchange… #44676 (#44731)

Cherry-picked from #44676

Co-authored-by: Gabriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mryange Mryange Mryange approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @924060929 @Mryange