Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](planner) FunctionCallExpr clone should be deep copy #44678

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[fix](planner) FunctionCallExpr clone should be deep copy #44678

merged 1 commit into from
Nov 28, 2024

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

should deep copy all attribute of FunctionCallExpr in copy constructor.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow force-pushed the fix_function_call_clone branch from cbdb9cf to 3f76560 Compare November 27, 2024 10:16
@morrySnow
Copy link
Contributor Author

run buildall

924060929
924060929 previously approved these changes Nov 27, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
[fix](planner) FunctionCallExpr clone should be deep copy
3d91035 
should deep copy all attribute of FunctionCallExpr in copy constructor
@morrySnow morrySnow force-pushed the fix_function_call_clone branch from 3f76560 to 3d91035 Compare November 27, 2024 11:23
@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@morrySnow
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit cf0b4c9 into apache:master Nov 28, 2024
24 of 26 checks passed
@morrySnow morrySnow deleted the fix_function_call_clone branch November 28, 2024 02:42
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@morrySnow
[fix](planner) FunctionCallExpr clone should be deep copy (#44678)
20debbb
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@morrySnow
[fix](planner) FunctionCallExpr clone should be deep copy (#44678)
813d02a
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
morrySnow added a commit that referenced this pull request Nov 28, 2024
@github-actions @morrySnow
branch-3.0: [fix](planner) FunctionCallExpr clone should be deep copy #…
fe88ab2 
…44678 (#44710)

Cherry-picked from #44678

Co-authored-by: morrySnow <[email protected]>
morrySnow added a commit that referenced this pull request Nov 29, 2024
@github-actions @morrySnow
branch-2.1: [fix](planner) FunctionCallExpr clone should be deep copy #…
6f868e4 
…44678 (#44711)

Cherry-picked from #44678

Co-authored-by: morrySnow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morrySnow @doris-robot @924060929 @starocean999