[fix](unique key) getEnableUniqueKeyMergeOnWrite should check keys type #44692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
16 tasks
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
bobhan1
approved these changes
Dec 3, 2024
|
run p0 |
|
run feut |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…pe (#44692) Problem Summary: Some user can create Duplicate keys table with `enable_unique_key_merge_on_write=true` in version 1.2, when they upgrade to version 2.0, some logic in BE treat such table as an unique key mow table, make a wrong query plan, which cause BE core. In the method `OlapTable::getEnableUniqueKeyMergeOnWrite()`, we should check if the table is a unique key table.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…pe (#44692) Problem Summary: Some user can create Duplicate keys table with `enable_unique_key_merge_on_write=true` in version 1.2, when they upgrade to version 2.0, some logic in BE treat such table as an unique key mow table, make a wrong query plan, which cause BE core. In the method `OlapTable::getEnableUniqueKeyMergeOnWrite()`, we should check if the table is a unique key table.
zhannngchen
added
dev/2.0.16-merged
dev/2.0.x
dev/2.1.x
and removed
dev/2.0.x
dev/2.1.8-merged
labels
zhannngchen
added a commit
that referenced
this pull request
Dec 3, 2024
…heck keys type #44692 (#44896) Cherry-picked from #44692 Co-authored-by: zhannngchen <[email protected]>
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Dec 3, 2024
…pe (apache#44692) Problem Summary: Some user can create Duplicate keys table with `enable_unique_key_merge_on_write=true` in version 1.2, when they upgrade to version 2.0, some logic in BE treat such table as an unique key mow table, make a wrong query plan, which cause BE core. In the method `OlapTable::getEnableUniqueKeyMergeOnWrite()`, we should check if the table is a unique key table.
zhannngchen
added a commit
that referenced
this pull request
Dec 3, 2024
…heck keys type #44692 (#44895) Cherry-picked from #44692 Co-authored-by: zhannngchen <[email protected]>
zhannngchen
pushed a commit
that referenced
this pull request
Dec 6, 2024
### What problem does this PR solve? as stated in #44692, Some user can create Duplicate keys table with `enable_unique_key_merge_on_write=true` successfully in version 1.2. After they upgrade to higher version, the incorrect table property still remains. Some logic in BE treat such table as an unique key mow table, makes a wrong query plan and BE may do partial update on duplicate table, which causes BE core. This PR add checks before doing partial update and return error when some preconditions are not met to prevent coredump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Some user can create Duplicate keys table with
enable_unique_key_merge_on_write=truein version 1.2, when they upgrade to version 2.0, some logic in BE treat such table as an unique key mow table, make a wrong query plan, which cause BE core.In the method
OlapTable::getEnableUniqueKeyMergeOnWrite(), we should check if the table is a unique key table.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)